[9/x] Test for mem::intrinsics::store_sw/load_sw, fix assert in get_inputs test (clk=451) and other errors
#238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenhat
changed the title
mem::intrinsics::store_sw, fix assert in get_inputs test (clk=451)mem::intrinsics::store_sw/load_sw, fix assert in get_inputs test (clk=451)
greenhat
force-pushed
the
greenhat/i230-get-inputs-clk451-assert
branch
from
bad9227 to
357916d
Compare
This was referenced Jul 8, 2024
greenhat
force-pushed
the
greenhat/i230-get-inputs-clk451-assert
branch
from
357916d to
a9c5689
Compare
greenhat
force-pushed
the
greenhat/emu-print-stack-option
branch
from
1ce9065 to
79d1c24
Compare
greenhat
force-pushed
the
greenhat/i230-get-inputs-clk451-assert
branch
from
a9c5689 to
b0edae2
Compare
greenhat
changed the title
mem::intrinsics::store_sw/load_sw, fix assert in get_inputs test (clk=451)mem::intrinsics::store_sw/load_sw, fix assert in get_inputs test (clk=451) and other errors
greenhat
force-pushed
the
greenhat/emu-print-stack-option
branch
from
79d1c24 to
fb59577
Compare
`intrinsics::mem::store_felt_unchecked`, `intrinsics::mem::load_sw` #230 - assert in `intrinsics::mem::replace_element`, - storing not in the word address in `intrinsics::mem::store_felt_unchecked`, -loading from not from a pointer, but a value(partial) in `intrinsics::mem::load_sw` causing "out of bounds memory access". Add test for `mem::intrinsics::store_sw/load_sw`
greenhat
force-pushed
the
greenhat/i230-get-inputs-clk451-assert
branch
from
b0edae2 to
41491cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is stacked on the #237 and should be merged after it
Close #234
Close #230
This PR fixes the following errors:
intrinsics::mem::replace_element,intrinsics::mem::store_felt_unchecked,intrinsics::mem::load_swcausing "out of bounds memory access".Adds proptest for
mem::intrinsics::store_sw/load_sw.