feat: rework test-harness for integration tests#1039
feat: rework test-harness for integration tests#1039lima-limon-inc wants to merge 4 commits into0xMiden:nextfrom
Conversation
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]> Suggested-by: Dennis Zadorozhnyi <[email protected]>
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
a74cccc to
e6df139
Compare
bitwalker
left a comment
There was a problem hiding this comment.
So the problem with the removal of compile_rust_package is that by calling miden build, we're not actually testing the right version of the compiler (i.e. we're testing whatever the current midenup toolchain has installed). Using miden build is correct for other parts of the project, but not the compiler itself (where we need to test things based on the current source of the compiler).
I think we probably need to keep compile_rust_package unfortunately, or have it invoke cargo miden build instead (and ensure that it is looking in the right place for the cargo-miden binary - which our test suite currently does, but if responsibility for that moves somewhere else, we'll need a way to ensure the right binaries are being used).
Let me know if I've misunderstood something though!
Tackles #981
This PR aims to remove some functionality from the compiler's testing crate and rely on
miden-protocol's testing crate.This includes the following changes:
create_note_from_packagefunction. This now relies onmiden-protocol'sNoteBuilder(which gotPackagesupport added into it in this PR).account_component_from_packagefunction which was replaced withAccountoComponent::from_package.compile_rust_packagemethod callsmiden buildinstead of the compiler's library.build_existing_basic_wallet_account_builderfunction.MockChainBuilder::add_existing_account_from_componentswhich was also added in PRNoteCreationConfigsince it was superseded byNoteBuilder.