Fix cross module constants and comprehension scoping #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d MIR translation
Al-Kindi-0
changed the title
Soulthym
reviewed
Jan 14, 2026
Collaborator
Soulthym
left a comment
Soulthym
left a comment
There was a problem hiding this comment.
Hey @Al-Kindi-0, I left a few comments below about clarifications and a minor nit regarding Boxing RangeExpr. The code itself looks good to me otherwise, great job!
| let current_item_node_index = self.get_node_index_or_add(¤t_item); | ||
| for (referenced_item, ref_type) in self.referenced.clone().iter() { | ||
| let referenced_item_node_index = self.get_node_index_or_add(referenced_item); | ||
| self.deps_graph.add_edge( |
Collaborator
There was a problem hiding this comment.
I'm assuming this is the part of the issue you encountered, we were overriding values without checking for their existence first?
This edit looks correct, just asking to confirm I understand the problem properly
| Default, | ||
| /// Access binds a sub-slice of a vector | ||
| Slice(RangeExpr), | ||
| Slice(Box<RangeExpr>), |
Collaborator
There was a problem hiding this comment.
Is there a reason to switching to a Box here instead of an owned RangeExpr?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR fixes two bugs related to cross-module imports and comprehension scoping:
Cross-module constant dependencies:
Constants used in comprehension iterables fail when imported across module boundaries.
Comprehension periodic binding scoping:
Iterating over a vector containing periodic column references causes the binding to be mistyped as PeriodicColumn, leading to "no entry found for key" panic.
Checklist before requesting a review
nextaccording to naming convention.CHANGELOG.md