Skip to content

Enforce errors for missing items in Import::Partial #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GarmashAlex wants to merge 1 commit into
base: next
Choose a base branch
from
Open

Enforce errors for missing items in Import::Partial #473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions parser/src/sema/import_resolver.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,16 @@ impl VisitMut<SemanticAnalysisError> for ImportResolver<'_> {
Ok(value) => value,
Err(err) => return ControlFlow::Break(err),
};
for export in imported_from.exports() {
let name = export.name();
// We fetch the item from the set, rather than simply
// check for containment, because we want the span associated
// with the item in the set, not the span associated with the
// export.
if let Some(item) = items.get(&name) {
self.import(module, *from, *item, export)?;
for item in items.iter() {
match imported_from.get(item) {
Some(export) => {
self.import(module, *from, *item, export)?;
},
None => {
return ControlFlow::Break(SemanticAnalysisError::ImportUndefined(
*from,
));
},
}
}
},
Expand Down