address issues #32
Closed
address issues #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r` trait (Plonky3#1152) * challenger: add observe_lifted to FieldChallenger trait * change name * fix name * fix trait bounds * minor change * minor change
…nky3#1155) * challenger: add unit tests for observe_base_as_algebra_element * fix comments
* Update lib.rs * Update Cargo.toml * Update koala_bear.rs * Update baby_bear.rs * Update bn254.rs * Update Cargo.toml * Update bn254.rs * Update baby_bear.rs * Update bn254.rs * Update koala_bear.rs * Update bn254.rs * Update baby_bear.rs * Update Cargo.toml * Update lib.rs * Update lib.rs * Update Cargo.toml * Update Cargo.toml * Update lib.rs * Update koala_bear.rs * Update baby_bear.rs * Update lib.rs * Update lib.rs * Update lib.rs * Update Cargo.toml * Update lib.rs * Update lib.rs * Update field-testing/src/lib.rs --------- Co-authored-by: AngusG <[email protected]>
* Change traits and add folders with lookups * Apply comments * Apply comment
* matrix: make HorizontallyTruncated more generic * small cleanup
Updates the requirements on [criterion](https://github.com/criterion-rs/criterion.rs) to permit the latest version. - [Release notes](https://github.com/criterion-rs/criterion.rs/releases) - [Changelog](https://github.com/criterion-rs/criterion.rs/blob/master/CHANGELOG.md) - [Commits](criterion-rs/criterion.rs@criterion-plot-v0.7.0...criterion-v0.8.0) --- updated-dependencies: - dependency-name: criterion dependency-version: 0.8.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* uni stark: small touchups * Update uni-stark/src/symbolic_expression.rs Co-authored-by: Robin Salen <[email protected]> * small touchup --------- Co-authored-by: Robin Salen <[email protected]>
* core: add error messages to Error enums via thiserror * sort cargo file
* feat: add SubAirBuilder * refactor: remove SubMatrixRowSlices and reuse HorizontallyTruncated * chore: clippy * chore: fmt * Update sub_builder.rs Co-authored-by: Thomas Coratger <[email protected]> * Update sub_builder.rs Co-authored-by: Thomas Coratger <[email protected]> * Update sub_builder.rs Co-authored-by: Thomas Coratger <[email protected]> * Update rc_sub_builder.rs Co-authored-by: Thomas Coratger <[email protected]> --------- Co-authored-by: Thomas Coratger <[email protected]>
* doc: add rustdoc links * more linking
* Allow users to impl either permute or permute_mut * Add comment to Permutation trait method indicating the circular nature of the trait definitions.
* Integrate lookups to prover and verifier * Apply comments * Apply comments and Clippy
* Work on automated releases - Added CI to trigger a crates.io release when a release PR is merged. - Added a script to generate a release PR (and temporarily modify sub-crate `Cargo.toml`s. - Added `release-plz.toml`. * A bit more work on automated release logic * Fixed some things * Now only runs on main * Cleanup * Removed old release scripts * `release-plz` CI now looks for the "release" label * Docs * Various squashed commits Removed unused release logic REMOVE ME!! Now using `GIT_TOKEN` again * (AI) Finished the logic to release * Apply suggestions from code review - Applied Syxton's new packages. Co-authored-by: AngusG <[email protected]> --------- Co-authored-by: AngusG <[email protected]>
* challenger: add observe_algebra_elements method * Update challenger/src/lib.rs Co-authored-by: AngusG <[email protected]> * fix comment * fix comment --------- Co-authored-by: AngusG <[email protected]>
* core: small touchups * touchups * touchups
* challenger: use observe_algebra_slice when possible * clippy * chore: pacify clippy --------- Co-authored-by: Robin Salen <[email protected]>
This was referenced Dec 11, 2025
This was referenced Dec 11, 2025
huitseeker
reviewed
Dec 11, 2025
huitseeker
left a comment
huitseeker
left a comment
There was a problem hiding this comment.
Thanks for addressing all of these, I left some notes inline!
Closed
|
@zhenfeizhang We are short on review bandwidth and will not be able to review this PR, which addresses #18, in a reasonable amount of time. As a consequence, we'll probably focus on #39. |
Author
|
sure no worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21 #23 #27 #29