feat: add fri params suitable for miden proving #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al-Kindi-0
reviewed
Dec 10, 2025
fri/src/config.rs
Outdated
| num_queries: 100, | ||
| proof_of_work_bits: 16, | ||
| mmcs, | ||
| log_folding_factor: 1, |
There was a problem hiding this comment.
I think we now have support for higher folding arity, right? If yes, we should use 4 to match our current Winterfell setting.
fri/src/config.rs
Outdated
| pub const fn create_miden_fri_params<Mmcs>(mmcs: Mmcs) -> FriParameters<Mmcs> { | ||
| FriParameters { | ||
| log_blowup: 4, | ||
| log_final_poly_len: 0, |
Al-Kindi-0
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 fri parameters constructors to be used for miden proving. On the air-script side, the PR and comment related to this change: 0xMiden/air-script#523 (comment)