feat: bump miden-client to v0.12 in crates #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- drop the usage of miden-multisig-coordinator-utils - use `Signature::to_prepared_signature` to obtain `Vec<Felt>` to be passed as tx args - make miden-multisig-client crate no_std - fix unit and integration tests to be compatible with the testnet using miden-client v0.12
hubcycle
commented
Nov 24, 2025
| let signatures = signatures | ||
| .into_iter() | ||
| .map(|s| s.map(miden_multisig_coordinator_utils::rpo_falcon512_signature_into_felt_vec)) | ||
| .map(|s| s.map(|s| Signature::RpoFalcon512(s).to_prepared_signature(Word::empty()))) |
Collaborator
Author
There was a problem hiding this comment.
I passed Word::empty() as the argument to satisfy the method invoking requirements although it should not be necessary for rpo falcon512 signature (see link).
rotorship
reviewed
Nov 24, 2025
crates/test-utils/src/lib.rs
Outdated
| // Block 4: Create second note | ||
| mock_chain.add_pending_note(OutputNote::Full(note_second.clone())); | ||
| // Block 4 | ||
| mock_chain.prove_next_block().unwrap(); |
Collaborator
There was a problem hiding this comment.
Is it necessary to prove so many blocks for the test to succeed?
Collaborator
Author
There was a problem hiding this comment.
Thanks for the suggestion, I removed the extra block proving calls and the multisig test does not fail, so I guess they were indeed redundant.
cc: @mmagician
…in coordinator-frontend (#20) * Restore coordinator-frontend changes: remove createFaucet, update AccountInterface to BasicWallet, use NoteFile.deserialize() * fix: fix cargo chef error in Dockerfile of coordinator backend * add network param to wallet adapter components * fix: fix decoding account address and bump miden wallet adapter dependency to v0.10.0 * fix: fix wallet not connected error and invalid signature error * chore: remove miden-wallet-adapter-react dependencies --------- Co-authored-by: Pradyumna-Bhardwaj <[email protected]>
hubcycle
force-pushed
the
18-upgrade-miden-client-dependency-to-v012
branch
from
5d5f0b8 to
d5913a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signature::to_prepared_signatureto obtainVec<Felt>to be passed as tx argsAccount::to_bech32andAccount::from_bech32to encode/decode account ids instead ofAddress.miden-objectsfrom all crates.Closes #18.