Open
Conversation
0xBeans
reviewed
Sep 14, 2022
| cache/ | ||
| out/ | ||
| artifacts/ | ||
| lib/ |
Owner
There was a problem hiding this comment.
typically we want to keep lib so ppl can just run forge install when playing with the repo
0xBeans
reviewed
Sep 14, 2022
| @@ -1,5 +1,5 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| pragma solidity ^0.8.13; | |||
0xBeans
reviewed
Sep 14, 2022
| } | ||
|
|
||
| constructor() ERC721("Conclusion", "CONCLUSION") {} | ||
| constructor() ERC721("The Last Work", "CONCLUSION") {} |
Owner
There was a problem hiding this comment.
lets do 'sunset' and 'sunrise' for POS
0xBeans
reviewed
Sep 14, 2022
| if (!mergeHasOccured()) { | ||
| lastWorkBlock = block.number; | ||
| } | ||
| function _assetPoW() internal { |
0xBeans
reviewed
Sep 14, 2022
| } | ||
|
|
||
| constructor() ERC721("Genesis", "GENESIS") {} | ||
| constructor() ERC721("New Genesis", "GENESIS") {} |
0xBeans
reviewed
Sep 14, 2022
|
|
||
| function checkForMergeAndUpdate() public { | ||
| if (genesisMergeBlock == 0 && mergeHasOccured()) { | ||
| function assertPoS() public { |
Owner
There was a problem hiding this comment.
i was thinking we could make this a function anyone could call just so we can keep updating the blocks (so we can guarantee not missing the POS block)
0xBeans
reviewed
Sep 14, 2022
| info.blockNum, | ||
| info.blockdifficulty | ||
| info.blockNumber, | ||
| genesisMergeBlock |
Owner
There was a problem hiding this comment.
this is suppose to be the block difficulty the minter minted at - for metadata purposes
Author
There was a problem hiding this comment.
PoS doesn't have block.difficulty (it's prevrandao then) so I re-purposed it to show when genesisMergeBlock (since it isn't known while PoW, so it's a nice compromise)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainly some small semantic changes for clarity.
one thing I did change was adding a block limit of 100 blocks after PoS.
for PoW you can mint until PoS.
I also addes very minor tests. I will need to consult you regarding the renderer, it looks good in the code but I'm unfamiliar with these. but anyways we can always setRenderer so I'm not worried about that.
good work, I believe we're good to go!