Fix API tests flakiness #454
Conversation
Kishan-Dhakan
commented
Oct 14, 2022
•
Kishan-Dhakan
commented
- Closes Blobber: /v1/file/referencepath & objecttree API tests and doc review #338
| @@ -11,20 +11,11 @@ import ( | |||
| ) | |||
|
|
|||
| func TestBlobberFileRefs(t *testing.T) { | |||
| t.Parallel() | |||
There was a problem hiding this comment.
Can't we still make this test run parallely along with making gosdk using one wallet at a time.
There was a problem hiding this comment.
I already left a comment on this. Yes, we can, cause @Kishan-Dhakan has fixed synchronization of actions for sdk client.
There was a problem hiding this comment.
It causes nonce related errors in running them in parallel. So I'm keeping them sequential for now. Since we plan on removing gosdk dependency soon anyhow.
| t := new(testing.T) | ||
|
|
||
| sdkWalletMnemonics = crypto.GenerateMnemonics(t) | ||
| sdkWallet = apiClient.RegisterWalletForMnemonic(t, sdkWalletMnemonics) | ||
| sdkClient.SetWallet(t, sdkWallet, sdkWalletMnemonics) | ||
|
|
There was a problem hiding this comment.
I think this decesion to register a wallet only once for sdk client is a good way to go, but also it's better to make this "initialization" in a separate function. It's a minor change
There was a problem hiding this comment.
Okay, agreed. Will refactor
There was a problem hiding this comment.
every test should have it's own independent setup eg. wallet and allocation, else a single shared wallet will cause issues with token accounting tests
I think this is again trying to avoid the issue of static globals rather than solving it
…_test into fix/use-one-wallet
@stewartie4 Created an issue for it here: 0chain/gosdk#642, since we can only test code as it is for now, we should get these tests in before mainnet. |
|
Agreed, I was hoping it would be a quick fix in test code, but as it is not we can keep this for now |
