Skip to content

Commit 68a40a3

Browse files
committed
Add pre-commit.
1 parent ad6436c commit 68a40a3

File tree

9 files changed

+48
-6
lines changed

9 files changed

+48
-6
lines changed

.github/workflows/test.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
fail-fast: false
4343
matrix:
4444
python-version: ["3.13"]
45-
tox-job: ["twine-check"]
45+
tox-job: ["linters", "twine-check"]
4646

4747
steps:
4848
- uses: actions/checkout@v4

.pre-commit-config.yaml

+22
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
repos:
2+
- repo: https://github.com/PyCQA/isort
3+
rev: 5.13.2
4+
hooks:
5+
- id: isort
6+
- repo: https://github.com/psf/black
7+
rev: 24.10.0
8+
hooks:
9+
- id: black
10+
- repo: https://github.com/pycqa/flake8
11+
rev: 7.1.1
12+
hooks:
13+
- id: flake8
14+
additional_dependencies:
15+
- flake8-docstrings
16+
- flake8-print
17+
- repo: https://github.com/adamchainz/blacken-docs
18+
rev: 1.19.1
19+
hooks:
20+
- id: blacken-docs
21+
additional_dependencies:
22+
- black==24.10.0

pyproject.toml

+7
Original file line numberDiff line numberDiff line change
@@ -33,3 +33,10 @@ Source = "https://github.com/zytedata/duplicate-url-discarder-rules"
3333

3434
[tool.setuptools.package-data]
3535
'duplicate_url_discarder_rules' = ['**/*.json']
36+
37+
[tool.black]
38+
target-version = ["py39", "py310", "py311", "py312", "py313"]
39+
40+
[tool.isort]
41+
profile = "black"
42+
multi_line_output = 3

setup.cfg

+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
[flake8]
2+
ignore = E203, E266, E501, W503, C901
3+
max-line-length = 88
4+
select = B,C,E,F,W,T4

tests/normalizer/test_normalizer.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
from duplicate_url_discarder.url_canonicalizer import UrlCanonicalizer
21
from duplicate_url_discarder.processors import NormalizerProcessor
2+
from duplicate_url_discarder.url_canonicalizer import UrlCanonicalizer
33

44
from duplicate_url_discarder_rules import RULE_PATHS
55

tests/queryRemovalExcept/test_query_removal_except.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
from duplicate_url_discarder.url_canonicalizer import UrlCanonicalizer
21
from duplicate_url_discarder.processors import QueryRemovalExceptProcessor
2+
from duplicate_url_discarder.url_canonicalizer import UrlCanonicalizer
33

44
from duplicate_url_discarder_rules import RULE_PATHS
55

tests/subpathRemoval/test_subpath_removal.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
from duplicate_url_discarder.url_canonicalizer import UrlCanonicalizer
21
from duplicate_url_discarder.processors import SubpathRemovalProcessor
2+
from duplicate_url_discarder.url_canonicalizer import UrlCanonicalizer
33

44
from duplicate_url_discarder_rules import RULE_PATHS
55

tests/test_rules.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,12 @@
22

33
from url_matcher import Patterns
44

5-
from duplicate_url_discarder_rules import RULE_PATHS, RULE_PATHS_ARTICLE, RULE_PATHS_PRODUCT, RULE_PATHS_COMMON
5+
from duplicate_url_discarder_rules import (
6+
RULE_PATHS,
7+
RULE_PATHS_ARTICLE,
8+
RULE_PATHS_COMMON,
9+
RULE_PATHS_PRODUCT,
10+
)
611

712

813
def test_rule_validity():

tox.ini

+5-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[tox]
2-
envlist = py39,py310,py311,py312,py313,twine-check
2+
envlist = py39,py310,py311,py312,py313,linters,twine-check
33

44
[testenv]
55
deps =
@@ -11,6 +11,10 @@ commands =
1111
py.test \
1212
{posargs:duplicate_url_discarder_rules tests}
1313

14+
[testenv:linters]
15+
deps = pre-commit
16+
commands = pre-commit run --all-files --show-diff-on-failure
17+
1418
[testenv:twine-check]
1519
deps =
1620
build

0 commit comments

Comments
 (0)