[Bug] Add support for all ID3 lyric frames

[Mitezuss]

Description

from where get the text embed on the mp3 ?

Steps to Reproduce

tried multiple field but not working

Expected Behavior

wanna see the lyrics

Screenshots

No response

Additional Context

No response

Device

No response

OS

Android 13

Version

Latest

Contribution Guidelines

• I agree to follow the Contribution Guidelines.

[Mitezuss]

@zyrouge

should be UNSYNCEDLYRICS

but after "Support synced and .lrc lyrics."

the lyric embed can not be read (is ignored, just use the file .lrc on latest version)

can implement a check for .lrc and if not exist use the unsyc lyric embeded ?

[zyrouge]

symphony/app/src/main/java/io/github/zyrouge/metaphony/metadata/id3v2/ID3v2Metadata.kt

Line 23 in 2b6b63a

override fun lyrics() = textFrame("lyrics", "lyrics-xxx")

Support for lyrics and lyrics-xxx is implemented. USLT or LST are not supported.

[zyrouge]

@zyrouge

should be

but after "Support synced and .lrc lyrics."

the lyric embed can not be read (is ignored, just use the file .lrc on latest version)

can implement a check for .lrc and if not exist use the unsyc lyric embeded ?

There is just too many tags used this. Lrc files always get the priority if they exist.

[Mitezuss]

Support for lyrics

the "LYRICS" field is ignored too

Lrc files always get the priority

yes, but the fields inside the mp3 is ignore anyway (if the file .lrc dnt exist)

(sry my bad english)

[zyrouge]

Support for lyrics

the "LYRICS" field is ignored too

Lrc files always get the priority

yes, but the fields inside the mp3 is ignore anyway (if the file .lrc dnt exist)

(sry my bad english)

As I mentioned lyrics and lyrics-xxx should work since I did test them.

[Mitezuss]

As I mentioned lyrics and lyrics-xxx should work since I did test them.

can share the mp3 to test ? not working for me =/ (on latest version, but on OLD version (without lrc feature) the field is detected)

like i said, after the version with "Support synced and .lrc lyrics." the field is ignored (Although there is no file .lrc)

[zyrouge]

Sure. The lyrics tag will not be used if lrc file is detected.

[daoxi]

Support for lyrics and lyrics-xxx is implemented. USLT or LST are not supported.

@zyrouge Sorry, but for ID3v2 (MP3 tagging), the USLT frame should probably be the most important/default one to be supported
(btw I'm not sure why you mentioned "LST" as there actually isn't any official frame/field with a "LST" ID in the ID3v2 standard)

In other words, if there's any ID3v2 lyrics frame that should be supported, in my opinion it should be USLT, because this is like the "go-to"/standard tag/frame for all the music software/apps out there, for example:
Musicolet, Poweramp, HibyMusic, Retro Music Player, Oto Music, and many others all support synchronized lyrics (LRC syntax) embedded in the USLT frame, furthermore, other players that only support plaintext lyrics (without timestamps) also use the USLT frame (e.g. iTunes, Stellio, Rocket Player, etc.).

 

There is just too many tags

For ID3v2, there're actually only 2 tags/frames dedicated for lyrics, which are:
USLT frame (which is the most important/default, as I've explained above) and SYLT frame (this one is technically for synchronised lyrics, but almost all apps don't support it and instead use USLT for embedded synchronized LRC lyrics)

@Mitezuss mentioned "UNSYNCEDLYRICS" and I guess it referred to the tag field name that Mp3tag uses, and as you can see from the link it's also mapped to the USLT frame for ID3v2