keys/boxes: Convert remaining GO_BACK command use into EXIT_COMPOSE.

Tests updated.
Hotkeys document regenerated.

Author: Niloth-p

docs/hotkeys.md

@@ -8,7 +8,6 @@
 |Show/hide Help Menu|<kbd>?</kbd>|
 |Show/hide Markdown Help Menu|<kbd>Meta</kbd> + <kbd>m</kbd>|
 |Show/hide About Menu|<kbd>Meta</kbd> + <kbd>?</kbd>|
-|Go back|<kbd>Esc</kbd>|
 |Open draft message saved in this session|<kbd>d</kbd>|
 |Copy information from About Menu to clipboard|<kbd>c</kbd>|
 |Redraw screen|<kbd>Ctrl</kbd> + <kbd>l</kbd>|
@@ -87,6 +86,7 @@
 |Autocomplete @mentions, #stream_names, :emoji: and topics|<kbd>Ctrl</kbd> + <kbd>f</kbd>|
 |Cycle through autocomplete suggestions in reverse|<kbd>Ctrl</kbd> + <kbd>r</kbd>|
 |Narrow to compose box message recipient|<kbd>Meta</kbd> + <kbd>.</kbd>|
+|Exit message compose box|<kbd>Esc</kbd>|
 |Insert new line|<kbd>Enter</kbd>|
 
 ## Editor: Navigation

tests/ui_tools/test_boxes.py

@@ -235,7 +235,7 @@ def test_not_calling_send_private_message_without_recipients(
 
         assert not write_box.model.send_private_message.called
 
-    @pytest.mark.parametrize("key", keys_for_command("GO_BACK"))
+    @pytest.mark.parametrize("key", keys_for_command("EXIT_COMPOSE"))
     def test__compose_attributes_reset_for_private_compose(
         self,
         key: str,
@@ -256,7 +256,7 @@ def test__compose_attributes_reset_for_private_compose(
         assert write_box.msg_write_box.edit_text == ""
         assert write_box.compose_box_status == "closed"
 
-    @pytest.mark.parametrize("key", keys_for_command("GO_BACK"))
+    @pytest.mark.parametrize("key", keys_for_command("EXIT_COMPOSE"))
     def test__compose_attributes_reset_for_stream_compose(
         self,
         key: str,
@@ -1516,7 +1516,7 @@ def test_keypress_SEND_MESSAGE_no_topic(
             (primary_key_for_command("AUTOCOMPLETE"), True, True, False),
             (primary_key_for_command("AUTOCOMPLETE_REVERSE"), True, True, False),
             # footer resets
-            (primary_key_for_command("GO_BACK"), True, False, True),
+            (primary_key_for_command("EXIT_COMPOSE"), True, False, True),
             ("space", True, False, True),
             ("k", True, False, True),
         ],

zulipterminal/config/keys.py

@@ -46,12 +46,6 @@ class KeyBinding(TypedDict):
         'help_text': 'Show/hide About Menu',
         'key_category': 'general',
     },
-    'GO_BACK': {
-        'keys': ['esc'],
-        'help_text': 'Go back',
-        'excluded_from_random_tips': False,
-        'key_category': 'general',
-    },
     'OPEN_DRAFT': {
         'keys': ['d'],
         'help_text': 'Open draft message saved in this session',
@@ -188,6 +182,11 @@ class KeyBinding(TypedDict):
         'help_text': 'Narrow to compose box message recipient',
         'key_category': 'msg_compose',
     },
+    'EXIT_COMPOSE': {
+        'keys': ['esc'],
+        'help_text': 'Exit message compose box',
+        'key_category': 'msg_compose',
+    },
     'TOGGLE_NARROW': {
         'keys': ['z'],
         'help_text':

zulipterminal/ui_tools/boxes.py

@@ -775,7 +775,7 @@ def keypress(self, size: urwid_Size, key: str) -> Optional[str]:
             if success:
                 self.msg_write_box.edit_text = ""
                 if self.msg_edit_state is not None:
-                    self.keypress(size, primary_key_for_command("GO_BACK"))
+                    self.keypress(size, primary_key_for_command("EXIT_COMPOSE"))
                     assert self.msg_edit_state is None
         elif is_command_key("NARROW_MESSAGE_RECIPIENT", key):
             if self.compose_box_status == "open_with_stream":
@@ -798,7 +798,7 @@ def keypress(self, size: urwid_Size, key: str) -> Optional[str]:
                     self.view.controller.report_error(
                         "Cannot narrow to message without specifying recipients."
                     )
-        elif is_command_key("GO_BACK", key):
+        elif is_command_key("EXIT_COMPOSE", key):
             self.send_stop_typing_status()
             self._set_compose_attributes_to_defaults()
             self.view.controller.exit_editor_mode()