api: Add save_snippets events and handle live-updates

PIG208 · PIG208 · commit 2f0d1b4dc6ac · 2025-05-16T19:07:49.000-04:00
diff --git a/lib/api/model/events.dart b/lib/api/model/events.dart
@@ -37,6 +37,13 @@ sealed class Event {
           case 'update': return RealmUserUpdateEvent.fromJson(json);
           default: return UnexpectedEvent.fromJson(json);
         }
+      case 'saved_snippets':
+        switch (json['op'] as String) {
+          case 'add': return SavedSnippetsAddEvent.fromJson(json);
+          case 'update': return SavedSnippetsUpdateEvent.fromJson(json);
+          case 'remove': return SavedSnippetsRemoveEvent.fromJson(json);
+          default: return UnexpectedEvent.fromJson(json);
+        }
       case 'stream':
         switch (json['op'] as String) {
           case 'create': return ChannelCreateEvent.fromJson(json);
@@ -336,6 +343,71 @@ class RealmUserUpdateEvent extends RealmUserEvent {
   Map<String, dynamic> toJson() => _$RealmUserUpdateEventToJson(this);
 }
 
+/// A Zulip event of type `saved_snippets`.
+///
+/// The corresponding API docs are in several places for
+/// different values of `op`; see subclasses.
+sealed class SavedSnippetsEvent extends Event {
+  @override
+  @JsonKey(includeToJson: true)
+  String get type => 'saved_snippets';
+
+  String get op;
+
+  SavedSnippetsEvent({required super.id});
+}
+
+/// A [SavedSnippetsEvent] with op `add`: https://zulip.com/api/get-events#saved_snippets-add
+@JsonSerializable(fieldRename: FieldRename.snake)
+class SavedSnippetsAddEvent extends SavedSnippetsEvent {
+  @override
+  String get op => 'add';
+
+  final SavedSnippet savedSnippet;
+
+  SavedSnippetsAddEvent({required super.id, required this.savedSnippet});
+
+  factory SavedSnippetsAddEvent.fromJson(Map<String, dynamic> json) =>
+    _$SavedSnippetsAddEventFromJson(json);
+
+  @override
+  Map<String, dynamic> toJson() => _$SavedSnippetsAddEventToJson(this);
+}
+
+/// A [SavedSnippetsEvent] with op `update`: https://zulip.com/api/get-events#saved_snippets-update
+@JsonSerializable(fieldRename: FieldRename.snake)
+class SavedSnippetsUpdateEvent extends SavedSnippetsEvent {
+  @override
+  String get op => 'update';
+
+  final SavedSnippet savedSnippet;
+
+  SavedSnippetsUpdateEvent({required super.id, required this.savedSnippet});
+
+  factory SavedSnippetsUpdateEvent.fromJson(Map<String, dynamic> json) =>
+    _$SavedSnippetsUpdateEventFromJson(json);
+
+  @override
+  Map<String, dynamic> toJson() => _$SavedSnippetsUpdateEventToJson(this);
+}
+
+/// A [SavedSnippetsEvent] with op `remove`: https://zulip.com/api/get-events#saved_snippets-remove
+@JsonSerializable(fieldRename: FieldRename.snake)
+class SavedSnippetsRemoveEvent extends SavedSnippetsEvent {
+  @override
+  String get op => 'remove';
+
+  final int savedSnippetId;
+
+  SavedSnippetsRemoveEvent({required super.id, required this.savedSnippetId});
+
+  factory SavedSnippetsRemoveEvent.fromJson(Map<String, dynamic> json) =>
+    _$SavedSnippetsRemoveEventFromJson(json);
+
+  @override
+  Map<String, dynamic> toJson() => _$SavedSnippetsRemoveEventToJson(this);
+}
+
 /// A Zulip event of type `stream`.
 ///
 /// The corresponding API docs are in several places for
diff --git a/lib/api/model/events.g.dart b/lib/api/model/events.g.dart
diff --git a/lib/model/saved_snippet.dart b/lib/model/saved_snippet.dart
@@ -0,0 +1,35 @@
+import 'package:collection/collection.dart';
+
+import '../api/model/events.dart';
+import '../api/model/model.dart';
+
+mixin SavedSnippetStore {
+  Map<int, SavedSnippet> get savedSnippets;
+}
+
+class SavedSnippetStoreImpl with SavedSnippetStore {
+  SavedSnippetStoreImpl({required Iterable<SavedSnippet> savedSnippets})
+    : _savedSnippets = {
+        for (final savedSnippet in savedSnippets)
+          savedSnippet.id: savedSnippet,
+      };
+
+  @override
+  late Map<int, SavedSnippet> savedSnippets = UnmodifiableMapView(_savedSnippets);
+  final Map<int, SavedSnippet> _savedSnippets;
+
+  void handleSavedSnippetsEvent(SavedSnippetsEvent event) {
+    switch (event) {
+      case SavedSnippetsAddEvent(:final savedSnippet):
+        _savedSnippets[savedSnippet.id] = savedSnippet;
+
+      case SavedSnippetsUpdateEvent(:final savedSnippet):
+        assert(_savedSnippets[savedSnippet.id]!.dateCreated
+                 == savedSnippet.dateCreated); // TODO(log)
+        _savedSnippets[savedSnippet.id] = savedSnippet;
+
+      case SavedSnippetsRemoveEvent(:final savedSnippetId):
+        _savedSnippets.remove(savedSnippetId);
+    }
+  }
+}
diff --git a/lib/model/store.dart b/lib/model/store.dart
@@ -29,6 +29,7 @@ import 'message_list.dart';
 import 'recent_dm_conversations.dart';
 import 'recent_senders.dart';
 import 'channel.dart';
+import 'saved_snippet.dart';
 import 'settings.dart';
 import 'typing_status.dart';
 import 'unreads.dart';
@@ -431,7 +432,7 @@ Uri? tryResolveUrl(Uri baseUrl, String reference) {
 /// This class does not attempt to poll an event queue
 /// to keep the data up to date.  For that behavior, see
 /// [UpdateMachine].
-class PerAccountStore extends PerAccountStoreBase with ChangeNotifier, EmojiStore, UserStore, ChannelStore, MessageStore {
+class PerAccountStore extends PerAccountStoreBase with ChangeNotifier, EmojiStore, SavedSnippetStore, UserStore, ChannelStore, MessageStore {
   /// Construct a store for the user's data, starting from the given snapshot.
   ///
   /// The global store must already have been updated with
@@ -485,6 +486,8 @@ class PerAccountStore extends PerAccountStoreBase with ChangeNotifier, EmojiStor
       emailAddressVisibility: initialSnapshot.emailAddressVisibility,
       emoji: EmojiStoreImpl(
         core: core, allRealmEmoji: initialSnapshot.realmEmoji),
+      savedSnippets: SavedSnippetStoreImpl(
+        savedSnippets: initialSnapshot.savedSnippets ?? []),
       userSettings: initialSnapshot.userSettings,
       typingNotifier: TypingNotifier(
         core: core,
@@ -523,6 +526,7 @@ class PerAccountStore extends PerAccountStoreBase with ChangeNotifier, EmojiStor
     required this.customProfileFields,
     required this.emailAddressVisibility,
     required EmojiStoreImpl emoji,
+    required SavedSnippetStoreImpl savedSnippets,
     required this.userSettings,
     required this.typingNotifier,
     required UserStoreImpl users,
@@ -534,6 +538,7 @@ class PerAccountStore extends PerAccountStoreBase with ChangeNotifier, EmojiStor
     required this.recentSenders,
   }) : _realmEmptyTopicDisplayName = realmEmptyTopicDisplayName,
        _emoji = emoji,
+       _savedSnippets = savedSnippets,
        _users = users,
        _channels = channels,
        _messages = messages;
@@ -619,6 +624,10 @@ class PerAccountStore extends PerAccountStoreBase with ChangeNotifier, EmojiStor
   ////////////////////////////////
   // Data attached to the self-account on the realm.
 
+  @override
+  Map<int, SavedSnippet> get savedSnippets => _savedSnippets.savedSnippets;
+  final SavedSnippetStoreImpl _savedSnippets;
+
   final UserSettings? userSettings; // TODO(server-5)
 
   final TypingNotifier typingNotifier;
@@ -868,6 +877,11 @@ class PerAccountStore extends PerAccountStoreBase with ChangeNotifier, EmojiStor
         autocompleteViewManager.handleRealmUserUpdateEvent(event);
         notifyListeners();
 
+      case SavedSnippetsEvent():
+        assert(debugLog('server event: saved_snippets/${event.op}'));
+        _savedSnippets.handleSavedSnippetsEvent(event);
+        notifyListeners();
+
       case ChannelEvent():
         assert(debugLog("server event: stream/${event.op}"));
         _channels.handleChannelEvent(event);
diff --git a/test/api/model/model_checks.dart b/test/api/model/model_checks.dart
@@ -21,6 +21,12 @@ extension UserChecks on Subject<User> {
   Subject<bool> get isSystemBot => has((x) => x.isSystemBot, 'isSystemBot');
 }
 
+extension SavedSnippetChecks on Subject<SavedSnippet> {
+  Subject<int> get id => has((x) => x.id, 'id');
+  Subject<String> get title => has((x) => x.title, 'title');
+  Subject<String> get content => has((x) => x.content, 'content');
+}
+
 extension ZulipStreamChecks on Subject<ZulipStream> {
 }
 
diff --git a/test/example_data.dart b/test/example_data.dart
@@ -250,6 +250,28 @@ final User thirdUser = user(fullName: 'Third User');
 
 final User fourthUser  = user(fullName: 'Fourth User');
 
+////////////////////////////////////////////////////////////////
+// Data attached to the self-account on the realm
+//
+
+int _nextSavedSnippetId() => _lastSavedSnippetId++;
+int _lastSavedSnippetId = 1;
+
+SavedSnippet savedSnippet({
+  int? id,
+  String? title,
+  String? content,
+  int? dateCreated,
+}) {
+  _checkPositive(id, 'saved snippet ID');
+  return SavedSnippet(
+    id: id ?? _nextSavedSnippetId(),
+    title: title ?? 'A saved snippet',
+    content: content ?? 'foo bar baz',
+    dateCreated: dateCreated ?? 1234567890, // TODO generate timestamp
+  );
+}
+
 ////////////////////////////////////////////////////////////////
 // Streams and subscriptions.
 //
diff --git a/test/model/saved_snippet.dart b/test/model/saved_snippet.dart
@@ -0,0 +1,44 @@
+import 'package:checks/checks.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:zulip/api/model/events.dart';
+import 'package:zulip/api/model/model.dart';
+
+import '../api/model/model_checks.dart';
+import '../example_data.dart' as eg;
+import 'store_checks.dart';
+
+void main() {
+  test('handleSavedSnippetsEvent', () async {
+    final store = eg.store(initialSnapshot: eg.initialSnapshot(
+      savedSnippets: [eg.savedSnippet(id: 101)]));
+    check(store).savedSnippets.values.single.id.equals(101);
+
+    await store.handleEvent(SavedSnippetsAddEvent(id: 1,savedSnippet:
+      eg.savedSnippet(
+        id: 102,
+        title: 'foo title',
+        content: 'foo content',
+      )));
+    check(store).savedSnippets.values.deepEquals(<Condition<Object?>>[
+      (it) => it.isA<SavedSnippet>().id.equals(101),
+      (it) => it.isA<SavedSnippet>()..id.equals(102)
+                                    ..title.equals('foo title')
+                                    ..content.equals('foo content')
+    ]);
+
+    await store.handleEvent(SavedSnippetsRemoveEvent(id: 1, savedSnippetId: 101));
+    check(store).savedSnippets.values.single.id.equals(102);
+
+    await store.handleEvent(SavedSnippetsUpdateEvent(id: 1, savedSnippet:
+      eg.savedSnippet(
+        id: 102,
+        title: 'bar title',
+        content: 'bar content',
+        dateCreated: store.savedSnippets.values.single.dateCreated,
+      )));
+    check(store).savedSnippets.values.single
+      ..id.equals(102)
+      ..title.equals('bar title')
+      ..content.equals('bar content');
+  });
+}
diff --git a/test/model/store_checks.dart b/test/model/store_checks.dart
@@ -55,6 +55,7 @@ extension PerAccountStoreChecks on Subject<PerAccountStore> {
   Subject<int> get accountId => has((x) => x.accountId, 'accountId');
   Subject<Account> get account => has((x) => x.account, 'account');
   Subject<int> get selfUserId => has((x) => x.selfUserId, 'selfUserId');
+  Subject<Map<int, SavedSnippet>> get savedSnippets => has((x) => x.savedSnippets, 'savedSnippets');
   Subject<UserSettings?> get userSettings => has((x) => x.userSettings, 'userSettings');
   Subject<Map<int, ZulipStream>> get streams => has((x) => x.streams, 'streams');
   Subject<Map<String, ZulipStream>> get streamsByName => has((x) => x.streamsByName, 'streamsByName');

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,12 @@ extension UserChecks on Subject<User> {`
`21`	`21`	`Subject<bool> get isSystemBot => has((x) => x.isSystemBot, 'isSystemBot');`
`22`	`22`	`}`
`23`	`23`
	`24`	`+extension SavedSnippetChecks on Subject<SavedSnippet> {`
	`25`	`+ Subject<int> get id => has((x) => x.id, 'id');`
	`26`	`+ Subject<String> get title => has((x) => x.title, 'title');`
	`27`	`+ Subject<String> get content => has((x) => x.content, 'content');`
	`28`	`+}`
	`29`	`+`
`24`	`30`	`extension ZulipStreamChecks on Subject<ZulipStream> {`
`25`	`31`	`}`
`26`	`32`