Skip to content

Commit 07f882d

Browse files
committed
content [nfc]: Update comments in UserMentionNode about UI design
1 parent 1d01177 commit 07f882d

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

lib/model/content.dart

+4-6
Original file line numberDiff line numberDiff line change
@@ -706,17 +706,15 @@ class UserMentionNode extends InlineContainerNode {
706706
const UserMentionNode({
707707
super.debugHtmlNode,
708708
required super.nodes,
709-
// required this.mentionType,
710-
// required this.isSilent,
711709
});
712710

713-
// We don't currently seem to need this information in code. Instead,
711+
// For the legacy design, we don't need this information in code; instead,
714712
// the inner text already shows how to communicate it to the user
715713
// (e.g., silent mentions' text lacks a leading "@"),
716714
// and we show that text in the same style for all types of @-mention.
717-
// If we need this information in the future, go ahead and add it here.
718-
// final UserMentionType mentionType;
719-
// final bool isSilent;
715+
// We'll need these for implementing the post-2023 Zulip design, though.
716+
// final UserMentionType mentionType; // TODO(#646)
717+
// final bool isSilent; // TODO(#647)
720718
}
721719

722720
sealed class EmojiNode extends InlineContentNode {

0 commit comments

Comments
 (0)