segmentation fault with example project from README

[alex-dukhno]

Hi thank you for this crate, I am considering to use it in my db project instead of sqlparser

However, when I tried to run simple project from README example:

use postgres_parser::*;

fn main() {
    let args: Vec<String> = std::env::args().collect();
    let query_string = args.get(1).expect("no arguments");
    let parse_list = match parse_query(query_string) {
        Ok(query) => query,
        Err(e) => {
            eprintln!("{:?}", e);
            std::process::exit(1);
        }
    };

    let as_json = serde_json::to_string_pretty(&parse_list).expect("failed to convert to json");
    println!("{}", as_json);
}

I got segmentation fault:

alex-dukhno@Alexs-MacBook Projects/test-pro (master %) » cargo run ../isomorphicdb/docs/user-guide/sql/basic_queries.sql
    Finished dev [unoptimized + debuginfo] target(s) in 0.03s
     Running `target/debug/test-pro ../isomorphicdb/docs/user-guide/sql/basic_queries.sql`
[1]    45017 segmentation fault  cargo run ../isomorphicdb/docs/user-guide/sql/basic_queries.sql

however, when I run one example (e.g. scanner) it works 🤷‍♂️ :

alex-dukhno@Alexs-MacBook Projects/postgres-parser (fix-workflow-for-mac-os) » cargo run --example scanner ../isomorphicdb/docs/user-guide/sql/basic_queries.sql
   Compiling postgres-parser v0.2.2 (/Users/alex-dukhno/Projects/postgres-parser)
    Finished dev [unoptimized + debuginfo] target(s) in 15.26s
     Running `target/debug/examples/scanner ../isomorphicdb/docs/user-guide/sql/basic_queries.sql`
#1
-- Copyright 2020 - present Alex Dukhno
--
-- Licensed under the Apache License, Version 2.0 (the "License");
-- you may not use this file except in compliance with the License.
-- You may obtain a copy of the License at
--
--     http://www.apache.org/licenses/LICENSE-2.0
--
-- Unless required by applicable law or agreed to in writing, software
-- distributed under the License is distributed on an "AS IS" BASIS,
-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-- See the License for the specific language governing permissions and
-- limitations under the License.

create schema SMOKE_QUERIES;
-- {"CreateSchemaStmt":{"schemaname":"smoke_queries","if_not_exists":false}}
....

any advice on how to troubleshoot this appreciated 😄

[eeeebbbbrrrr]

That's interesting. Can you post the contents of "basic_queries.sql"?

Also, can you run it via gdb/lldb to get a backtrace?

[alex-dukhno]

Can you post the contents of "basic_queries.sql"?

content of the file could be found here https://github.com/alex-dukhno/isomorphicdb/blob/main/docs/user-guide/sql/basic_queries.sql

Also, can you run it via gdb/lldb to get a backtrace?

let me set it up and try to run it

[eeeebbbbrrrr]

also, I suppose it's worth pointing out that that example is meant to be run as: cargo run "SQL STATEMENT HERE", not taking a path to a file.

That said, you should have just gotten a parse error, not a core dump

[alex-dukhno]

I configured https://github.com/japaric/rust-san#how-to-use-the-sanitizers
This is what I got when run project

alex-dukhno@Alexs-MacBook Projects/test-pro (master %) » RUSTFLAGS="-Z sanitizer=$SAN" cargo run --target x86_64-apple-darwin ../isomorphicdb/docs/user-guide/sql/basic_queries.sql
    Finished dev [unoptimized + debuginfo] target(s) in 0.15s
     Running `target/x86_64-apple-darwin/debug/test-pro ../isomorphicdb/docs/user-guide/sql/basic_queries.sql`
AddressSanitizer:DEADLYSIGNAL
=================================================================
==59457==ERROR: AddressSanitizer: SEGV on unknown address (pc 0x7fff2044b3ee bp 0x7ffeea67cbd0 sp 0x7ffeea67cba8 T0)
==59457==The signal is caused by a READ memory access.
==59457==Hint: this fault was caused by a dereference of a high value address (see register values below).  Dissassemble the provided pc to learn which register was used.
    #0 0x7fff2044b3ee in stack_not_16_byte_aligned_error+0x0 (libdyld.dylib:x86_64+0x143ee)
    #1 0x105aa9dab in raw_parser+0x3b (test-pro:x86_64+0x100529dab)
    #2 0x105a2a533 in postgres_parser::parser::parse_query::raw_parser_wrapper::h3445a9b124aa3ee1 parser.rs:119
    #3 0x105a28593 in postgres_parser::parser::parse_query::hdfbbb62e7b860e17 parser.rs:190
    #4 0x105708594 in test_pro::main::h67fdad59256500e9 main.rs:6
    #5 0x10570b29d in core::ops::function::FnOnce::call_once::he87eed73c0cb45c5 function.rs:227
    #6 0x10558d76e in std::sys_common::backtrace::__rust_begin_short_backtrace::hddb5b10bbc852178 backtrace.rs:125
    #7 0x1057147cf in std::rt::lang_start::_$u7b$$u7b$closure$u7d$$u7d$::hf018630f157b2693 rt.rs:66
    #8 0x105b15923 in std::rt::lang_start_internal::h6cd9161d564e26bc rt.rs:51
    #9 0x10571472b in std::rt::lang_start::hc1b36c2fbbf96bb5 rt.rs:65
    #10 0x105708f31 in main+0x21 (test-pro:x86_64+0x100188f31)
    #11 0x7fff2044c620 in start+0x0 (libdyld.dylib:x86_64+0x15620)

==59457==Register values:
rax = 0x0000000000005e38  rbx = 0x00007ffeea67cee0  rcx = 0x00007ffeea67cbe8  rdx = 0x0000000000000000
rdi = 0x0000625000005218  rsi = 0x0000000000000400  rbp = 0x00007ffeea67cbd0  rsp = 0x00007ffeea67cba8
 r8 = 0x0000000000000020   r9 = 0x0000000000000001  r10 = 0x00000001107ee450  r11 = 0x0000000105c804b0
r12 = 0x00007ffeea67d480  r13 = 0x00007ffeea67d4a0  r14 = 0xf3f3f3f8f8f8f8f8  r15 = 0xf2f2f2f8f8f8f2f2
AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV (libdyld.dylib:x86_64+0x143ee) in stack_not_16_byte_aligned_error+0x0
==59457==ABORTING
[1]    59457 abort      RUSTFLAGS="-Z sanitizer=$SAN" cargo run --target x86_64-apple-darwin

[eeeebbbbrrrr]

That’s helpful. Thanks. It crashed in Postgres’ code which means I’ve got a bug somewhere on the rust side (likely). I’ll investigate.

But like I said above, you’re using that example wrong. :)

[alex-dukhno]

But like I said above, you’re using that example wrong. :)

Give me a minute 😄
This is with cargo run "SQL STATEMENT HERE" example

alex-dukhno@Alexs-MacBook Projects/test-pro (master %) » RUSTFLAGS="-Z sanitizer=$SAN" cargo run --target x86_64-apple-darwin "create schema schema_name"
    Finished dev [unoptimized + debuginfo] target(s) in 0.04s
     Running `target/x86_64-apple-darwin/debug/test-pro 'create schema schema_name'`
'"create schema schema_name"'
AddressSanitizer:DEADLYSIGNAL
=================================================================
==59737==ERROR: AddressSanitizer: SEGV on unknown address (pc 0x7fff2044b3ee bp 0x7ffee9174af0 sp 0x7ffee9174ac8 T0)
==59737==The signal is caused by a READ memory access.
==59737==Hint: this fault was caused by a dereference of a high value address (see register values below).  Dissassemble the provided pc to learn which register was used.
    #0 0x7fff2044b3ee in stack_not_16_byte_aligned_error+0x0 (libdyld.dylib:x86_64+0x143ee)
    #1 0x106fb1d5b in raw_parser+0x3b (test-pro:x86_64+0x100529d5b)
    #2 0x106f324e3 in postgres_parser::parser::parse_query::raw_parser_wrapper::h3445a9b124aa3ee1 parser.rs:119
    #3 0x106f30543 in postgres_parser::parser::parse_query::hdfbbb62e7b860e17 parser.rs:190
    #4 0x106c10568 in test_pro::main::h67fdad59256500e9 main.rs:7
    #5 0x106c1324d in core::ops::function::FnOnce::call_once::he87eed73c0cb45c5 function.rs:227
    #6 0x106a954be in std::sys_common::backtrace::__rust_begin_short_backtrace::hddb5b10bbc852178 backtrace.rs:125
    #7 0x106c1c77f in std::rt::lang_start::_$u7b$$u7b$closure$u7d$$u7d$::hf018630f157b2693 rt.rs:66
    #8 0x10701d8d3 in std::rt::lang_start_internal::h6cd9161d564e26bc rt.rs:51
    #9 0x106c1c6db in std::rt::lang_start::hc1b36c2fbbf96bb5 rt.rs:65
    #10 0x106c10ee1 in main+0x21 (test-pro:x86_64+0x100188ee1)
    #11 0x7fff2044c620 in start+0x0 (libdyld.dylib:x86_64+0x15620)

==59737==Register values:
rax = 0x0000000000005e38  rbx = 0x00007ffee9174e00  rcx = 0x00007ffee9174b08  rdx = 0x0000000000000000
rdi = 0x0000625000005218  rsi = 0x0000000000000400  rbp = 0x00007ffee9174af0  rsp = 0x00007ffee9174ac8
 r8 = 0x0000000000000007   r9 = 0xffffe3b5fffff5c4  r10 = 0x000000010baeb450  r11 = 0x00000001071884b0
r12 = 0x00007ffee91753a0  r13 = 0x00007ffee91753c0  r14 = 0xf3f3f3f8f8f8f8f8  r15 = 0xf2f2f2f8f8f8f2f2
AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV (libdyld.dylib:x86_64+0x143ee) in stack_not_16_byte_aligned_error+0x0
==59737==ABORTING
[1]    59737 abort      RUSTFLAGS="-Z sanitizer=$SAN" cargo run --target x86_64-apple-darwin

[eeeebbbbrrrr]

What kind of MacBook do you have? Is it a new M1?

[alex-dukhno]

alex-dukhno@Alexs-MacBook Projects/test-pro (master %) » /Volumes/Macintosh\ HD/usr/sbin/system_profiler SPHardwareDataType
Hardware:

    Hardware Overview:

      Model Name: MacBook Pro
      Model Identifier: MacBookPro16,1
      Processor Name: 8-Core Intel Core i9
      Processor Speed: 2,3 GHz
      Number of Processors: 1
      Total Number of Cores: 8
      L2 Cache (per Core): 256 KB
      L3 Cache: 16 MB
      Hyper-Threading Technology: Enabled
      Memory: 16 GB
      System Firmware Version: 1554.80.3.0.0 (iBridge: 18.16.14346.0.0,0)
      Serial Number (system): C02DX15EMD6Q
      Hardware UUID: 13B60DC7-4A06-5A78-8A14-B5673CC5331D
      Provisioning UDID: 13B60DC7-4A06-5A78-8A14-B5673CC5331D
      Activation Lock Status: Enabled

[eeeebbbbrrrr]

So the "scanner" example works fine, but the basic example that simply calls the parse_query() function crashes. Weird. Ultimately, that's what the scanner example does too.

I can't re-create this locally on my MacBook. Still looking...

[eeeebbbbrrrr]

what version of Rust are you using? I'm kinda stumped at the moment. There's gotta be some difference between our environments.

[alex-dukhno]

what version of Rust are you using? I'm kinda stumped at the moment. There's gotta be some difference between our environments.

rustc -V                                                                                                                                                                                (main)isomorphicdb
rustc 1.50.0 (cb75ad5db 2021-02-10)

Ok, so I run the following experiment.

1. I copied the scanner example into my project and run it - it fails with sigfault.
2. I copied my project code instead of scanner code it worked out ...

I suppose the difference somewhere in project configuration ...

[eeeebbbbrrrr]

can you tar up your example project that fails and post it here? or email it to me: eebbrr @ gmail dot com

[eeeebbbbrrrr]

I was on rustc 1.49.0 (e1884a8e3 2020-12-29) -- just upgraded to 1.50.0 and am rebuilding everything.

[alex-dukhno]

test-pro.tar.gz

[eeeebbbbrrrr]

Your project works for me:

 cargo run
    Updating crates.io index
  Downloaded libloading v0.7.0
  Downloaded clang-sys v1.1.1
  Downloaded 2 crates (62.8 KB) in 0.61s
...
   Compiling test-pro v0.1.0 (/Users/e_ridge/Downloads/test-pro)
warning: unused variable: `i`
 --> src/main.rs:7:10
  |
7 |     for (i, stmt) in scanner.into_iter().enumerate() {
  |          ^ help: if this is intentional, prefix it with an underscore: `_i`
  |
  = note: `#[warn(unused_variables)]` on by default

warning: 1 warning emitted

    Finished dev [unoptimized + debuginfo] target(s) in 49.84s
     Running `target/debug/test-pro`
true
{
  "SelectStmt": {
    "targetList": [
      {
        "ResTarget": {
          "val": {
            "A_Const": {
              "val": {
                "int": 1
              }
            }
          }
        }
      }
    ],
    "limitOption": "LIMIT_OPTION_COUNT",
    "op": "SETOP_NONE",
    "all": false
  }
}