Add Pool.Take method in sqlitemigration (#97)

Co-authored-by: Ross Light <[email protected]>

Author: blmhemu

Diff for: CHANGELOG.md

@@ -11,6 +11,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
+- `sqlitemigration.Pool` now has a new method `Take`
+  so that it implements a common interface with `sqlitex.Pool`
+  ([#97](https://github.com/zombiezen/go-sqlite/pull/97)).
 - Documented `OpenWAL` behavior on `sqlite.OpenConn`.
 
 ### Fixed

Diff for: sqlitemigration/sqlitemigration.go

@@ -130,8 +130,42 @@ func (p *Pool) Close() error {
 	return p.pool.Close()
 }
 
-// Get gets an SQLite connection from the pool.
+// Get obtains an SQLite connection from the pool,
+// waiting until the initial migration is complete.
+// Get is identical to [Pool.Take].
+//
+// If no connection is available,
+// Get will block until at least one connection is returned with [Pool.Put],
+// or until either the Pool is closed or the context is canceled.
+// If no connection can be obtained
+// or an error occurs while preparing the connection,
+// an error is returned.
+//
+// The provided context is also used to control the execution lifetime of the connection.
+// See [sqlite.Conn.SetInterrupt] for details.
+//
+// Applications must ensure that all non-nil Conns returned from Get
+// are returned to the same Pool with [Pool.Put].
 func (p *Pool) Get(ctx context.Context) (*sqlite.Conn, error) {
+	return p.Take(ctx)
+}
+
+// Take obtains an SQLite connection from the pool,
+// waiting until the initial migration is complete.
+//
+// If no connection is available,
+// Take will block until at least one connection is returned with [Pool.Put],
+// or until either the Pool is closed or the context is canceled.
+// If no connection can be obtained
+// or an error occurs while preparing the connection,
+// an error is returned.
+//
+// The provided context is also used to control the execution lifetime of the connection.
+// See [sqlite.Conn.SetInterrupt] for details.
+//
+// Applications must ensure that all non-nil Conns returned from Take
+// are returned to the same Pool with [Pool.Put].
+func (p *Pool) Take(ctx context.Context) (*sqlite.Conn, error) {
 	tick := time.NewTicker(5 * time.Second)
 	for ready := false; !ready; {
 		// Inform Pool.open to keep trying.