[Question]: Puppeteer event parsing

[Valerioageno]

I'm trying to use the library with playwrigth (that uses puppeteer under the hood) but I have an issue with the events sent with the /envelope sentry's endpoint.

Basically the event envelope type on puppeteer is not recorded on the reports array.

// testkit.ts
const createPuppeteerHandler = (baseUrl: string) => (request: any) => {
    const url = request.url()
    if (!url.startsWith(baseUrl)) {
      return
    }
    const path = url.substring(baseUrl.length)
    if (/\/api\/[0-9]*\/store/.test(path)) {
      reports.push(transformReport(JSON.parse(request.postData())))
    }
    if (/\/api\/[0-9]*\/envelope/.test(path)) { // <-- Here we are not handling the event
      const { type, payload } = parseEnvelopeRequest(request.postData())
      if (type === 'transaction') {
        transactions.push(transformTransaction(payload))
      }
    }
  }

// parser.ts
export function handleEnvelopeRequestData( // <-- This function correctly handles the "event"
  requestBody: any,
  testkit: Testkit
): void {
  const { type, payload } = parseEnvelopeRequest(requestBody)

  if (type === 'transaction') {
    testkit.transactions().push(transformTransaction(payload))
  } else if (type === 'event') {
    testkit.reports().push(transformReport(payload))
  }
}

Is there a reason for that? Eventually I can open a Pull Request for it.

[zivl]

hey @Valerioageno
yeah sure it looks like a good feature to add, would appreciate a PR for it

[github-actions]

Stale issue message

[github-actions]

Stale issue message

[github-actions]

Stale issue message

[github-actions]

Stale issue message

[zivl]

@Valerioageno we are now working on releasing the next major version of sentry-testkit.
would you like to PR your suggestion?

[Valerioageno]

Sorry @zivl, I completely forgot about this issue... I don't have room right now to do the PR