fix modbus errors by upgrading to eModbus 1.7.0 (#9)

* switch eModbus to StreamRTU branch

* update to eModbus 1.7.0

* cleanup

* update actions

* https://docs.platformio.org/en/stable/integration/ci/github-actions.html

Author: zivillian

.github/workflows/main.yml

@@ -8,29 +8,23 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v2
-    - name: Cache pip
-      uses: actions/cache@v2
-      with:
-        path: ~/.cache/pip
-        key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }}
-        restore-keys: |
-          ${{ runner.os }}-pip-
-    - name: Cache PlatformIO
-      uses: actions/cache@v2
-      with:
-        path: ~/.platformio
-        key: ${{ runner.os }}-${{ hashFiles('**/lockfiles') }}
-    - name: Set up Python
-      uses: actions/setup-python@v2
-    - name: Install PlatformIO
-      run: |
-        python -m pip install --upgrade pip
-        pip install --upgrade platformio
-    - name: Run PlatformIO
-      run: pio run -e esp32release
-    - name: Upload artifacts
-      uses: actions/upload-artifact@v3
-      with:
-        name: image
-        path: .pio/build/esp32release/firmware.bin
+      - uses: actions/checkout@v3
+      - uses: actions/cache@v3
+        with:
+          path: |
+            ~/.cache/pip
+            ~/.platformio/.cache
+          key: ${{ runner.os }}-pio
+      - uses: actions/setup-python@v4
+        with:
+          python-version: '3.9'
+      - name: Install PlatformIO Core
+        run: pip install --upgrade platformio
+
+      - name: Build PlatformIO Project
+        run: pio run -e esp32release
+      - name: Upload artifacts
+        uses: actions/upload-artifact@v3
+        with:
+          name: image
+          path: .pio/build/esp32release/firmware.bin

platformio.ini

@@ -17,7 +17,7 @@
     lib_deps = 
 	    https://github.com/tzapu/WiFiManager.git
 	    https://github.com/me-no-dev/ESPAsyncWebServer.git
-	    eModbus
+	    miq19/eModbus @ ^1.7.0
     monitor_speed = 115200
 
 

src/main.cpp

@@ -31,6 +31,7 @@ void setup() {
   dbgln("[wifi] finished");
   dbgln("[modbus] start");
 
+  RTUutils::prepareHardwareSerial(modbusSerial);
 #if defined(RX_PIN) && defined(TX_PIN)
   // use rx and tx-pins if defined in platformio.ini
   modbusSerial.begin(config.getModbusBaudRate(), config.getModbusConfig(), RX_PIN, TX_PIN );
@@ -40,9 +41,9 @@ void setup() {
   modbusSerial.begin(config.getModbusBaudRate(), config.getModbusConfig());
 #endif
 
-  MBclient = new ModbusClientRTU(modbusSerial, config.getModbusRtsPin());
+  MBclient = new ModbusClientRTU(config.getModbusRtsPin());
   MBclient->setTimeout(1000);
-  MBclient->begin();
+  MBclient->begin(modbusSerial);
   for (uint8_t i = 1; i < 248; i++)
   {
     MBbridge.attachServer(i, i, ANY_FUNCTION_CODE, MBclient);