add support for multiple CSP directives #3720
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dontgitit
requested review from
987Nabil,
jdegoes,
kyri-petrou and
vigoo
as code owners
✅ Deploy Preview for zio-http ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
dontgitit
force-pushed
the
multiple-csp-directives
branch
from
ba96aa3 to
1b07100
Compare
dontgitit
commented
Oct 1, 2025
|
|
||
| final case class Host(uri: URI) extends Source | ||
| object Source { | ||
| case object none extends Source { |
Contributor
Author
There was a problem hiding this comment.
I wonder if while we're at it, this should be changed to None to be consistent with all the others?
Contributor
There was a problem hiding this comment.
We can't change this. That would be a breaking change
dontgitit
force-pushed
the
multiple-csp-directives
branch
from
e8306a2 to
33e9fbb
Compare
undo some formatting changes use List instead of Seq remove unused import
987Nabil
force-pushed
the
multiple-csp-directives
branch
from
33e9fbb to
33b6377
Compare
987Nabil
requested changes
Nov 17, 2025
|
|
||
| // scalafmt: { maxColumn = 180 } | ||
| sealed trait ContentSecurityPolicy extends Header { | ||
| final case class ContentSecurityPolicy(directives: List[ContentSecurityPolicy.Directive]) extends Header { |
Contributor
There was a problem hiding this comment.
This change is not binary compatible. We can't do that.
Contributor
Author
There was a problem hiding this comment.
I'm not sure how to implement this change without breaking binary compatibility...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3719