From 1b3d8c4f36ba01be4cb737f0fe62d9eba68384a6 Mon Sep 17 00:00:00 2001 From: Bhushan Deshmukh Date: Tue, 7 May 2024 15:42:06 -0700 Subject: [PATCH] using botocore clienterror exception --- zdatasets/tests/utils/test_secret_fetcher.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/zdatasets/tests/utils/test_secret_fetcher.py b/zdatasets/tests/utils/test_secret_fetcher.py index 4fe2aca..6c6a6d5 100644 --- a/zdatasets/tests/utils/test_secret_fetcher.py +++ b/zdatasets/tests/utils/test_secret_fetcher.py @@ -2,6 +2,7 @@ import os import unittest from unittest import mock +from botocore.exceptions import ClientError import boto3 import pytest @@ -109,11 +110,11 @@ def test_fetch_aws_secret(): SecretFetcher(aws_secret_arn="not-json-decodable", key="key").value # Empty string - with pytest.raises(ValueError) as ve: + with pytest.raises(ClientError) as ce: SecretFetcher(aws_secret_arn="empty") assert ( "Secrets Manager can't find the specified secret value for staging label: AWSCURRENT" - == ve.value.response["Error"]["Message"]) + == ce.value.response["Error"]["Message"]) @mock.patch("zdatasets.utils.secret_fetcher.get_current_namespace")