Skip to content

Commit 9a0b570

Browse files
committedMay 31, 2024·
AIP-8457 remove kfp dependencies
- only leave those necessary to compile an Argo Workflow using KFP
1 parent 58ae174 commit 9a0b570

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed
 

‎kfp/_auth.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@
2121
from google.auth.transport.requests import Request
2222
import google.oauth2.credentials
2323
import google.oauth2.service_account
24-
import requests_toolbelt.adapters.appengine
24+
# AIP-8457(talebz): WFSDK requests-toolbelt dependency breaks KFNB "pip install poetry"
25+
# import requests_toolbelt.adapters.appengine
2526
from webbrowser import open_new_tab
2627
import requests
2728
import json

‎kfp/components/_component_store.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010
import requests
1111
import tempfile
1212
from typing import Callable, Iterable
13-
from uritemplate import URITemplate
13+
# AIP-8457(talebz): WFSDK requests-toolbelt dependency breaks KFNB "pip install poetry"
14+
# from uritemplate import URITemplate
1415
from . import _components as comp
1516
from .structures import ComponentReference
1617
from ._key_value_store import KeyValueStore

‎setup.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -21,23 +21,23 @@
2121
""",
2222
install_requires=[
2323
"requests",
24-
"urllib3<2.0.0", # see requests break https://github.com/kubeflow/pipelines/pull/9323
24+
# "urllib3<2.0.0", # see requests break https://github.com/kubeflow/pipelines/pull/9323
2525
"boto3",
2626
"pylint",
2727
# required for KFP
2828
"absl-py>=0.9,<=0.11",
2929
"Deprecated>=1.2.7,<2",
3030
"docstring-parser>=0.7.3,<1",
3131
"fire>=0.3.1,<1",
32-
"googleapis-common-protos>=1.6.0,<2",
32+
# "googleapis-common-protos>=1.6.0,<2",
3333
"jsonschema>=4.19.2,<5",
3434
"kfp-pipeline-spec>=0.1.13,<0.2.0",
35-
"kfp-server-api>=1.1.2,<2.0.0",
35+
# "kfp-server-api>=1.1.2,<2.0.0",
3636
"kubernetes>=8.0.0,<27",
3737
"protobuf>=3.13.0,<4",
3838
"pyyaml>=5.3,<7",
39-
"requests-toolbelt>=0.8.0,<1",
40-
"uritemplate>=3.0.1,<4",
39+
# "requests-toolbelt>=0.8.0,<1",
40+
# "uritemplate>=3.0.1,<4",
4141
],
4242
tests_require=["coverage"],
4343
extras_require={

0 commit comments

Comments
 (0)
Please sign in to comment.