Skip to content

Commit 19056cb

Browse files
andrewrkandrewrk
authored
Merge pull request #14024 from Vexu/overflow-arithmetic
Make overflow arithmetic builtins return tuples
2 parents 55c3efc + a777373 commit 19056cb

40 files changed

+700
-612
lines changed

‎doc/langref.html.in

Lines changed: 26 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -5413,14 +5413,14 @@ pub fn parseU64(buf: []const u8, radix: u8) !u64 {
54135413
}
54145414

54155415
// x *= radix
5416-
if (@mulWithOverflow(u64, x, radix, &x)) {
5417-
return error.Overflow;
5418-
}
5416+
var ov = @mulWithOverflow(x, radix);
5417+
if (ov[1] != 0) return error.OverFlow;
5418+
54195419

54205420
// x += digit
5421-
if (@addWithOverflow(u64, x, digit, &x)) {
5422-
return error.Overflow;
5423-
}
5421+
ov = @addWithOverflow(ov[0], digit);
5422+
if (ov[1] != 0) return error.OverFlow;
5423+
x = ov[0];
54245424
}
54255425

54265426
return x;
@@ -5832,14 +5832,16 @@ test "merge error sets" {
58325832
{#code_begin|test|inferred_error_sets#}
58335833
// With an inferred error set
58345834
pub fn add_inferred(comptime T: type, a: T, b: T) !T {
5835-
var answer: T = undefined;
5836-
return if (@addWithOverflow(T, a, b, &answer)) error.Overflow else answer;
5835+
const ov = @addWithOverflow(a, b);
5836+
if (ov[1] != 0) return error.Overflow;
5837+
return ov[0];
58375838
}
58385839

58395840
// With an explicit error set
58405841
pub fn add_explicit(comptime T: type, a: T, b: T) Error!T {
5841-
var answer: T = undefined;
5842-
return if (@addWithOverflow(T, a, b, &answer)) error.Overflow else answer;
5842+
const ov = @addWithOverflow(a, b);
5843+
if (ov[1] != 0) return error.Overflow;
5844+
return ov[0];
58435845
}
58445846

58455847
const Error = error {
@@ -7632,11 +7634,9 @@ test "global assembly" {
76327634
</p>
76337635
{#header_close#}
76347636
{#header_open|@addWithOverflow#}
7635-
<pre>{#syntax#}@addWithOverflow(comptime T: type, a: T, b: T, result: *T) bool{#endsyntax#}</pre>
7637+
<pre>{#syntax#}@addWithOverflow(a: anytype, b: anytype) struct { @TypeOf(a, b), u1 }{#endsyntax#}</pre>
76367638
<p>
7637-
Performs {#syntax#}result.* = a + b{#endsyntax#}. If overflow or underflow occurs,
7638-
stores the overflowed bits in {#syntax#}result{#endsyntax#} and returns {#syntax#}true{#endsyntax#}.
7639-
If no overflow or underflow occurs, returns {#syntax#}false{#endsyntax#}.
7639+
Performs {#syntax#}a + b{#endsyntax#} and returns a tuple with the result and a possible overflow bit.
76407640
</p>
76417641
{#header_close#}
76427642
{#header_open|@alignCast#}
@@ -8695,11 +8695,9 @@ test "@wasmMemoryGrow" {
86958695
{#header_close#}
86968696

86978697
{#header_open|@mulWithOverflow#}
8698-
<pre>{#syntax#}@mulWithOverflow(comptime T: type, a: T, b: T, result: *T) bool{#endsyntax#}</pre>
8698+
<pre>{#syntax#}@mulWithOverflow(a: anytype, b: anytype) struct { @TypeOf(a, b), u1 }{#endsyntax#}</pre>
86998699
<p>
8700-
Performs {#syntax#}result.* = a * b{#endsyntax#}. If overflow or underflow occurs,
8701-
stores the overflowed bits in {#syntax#}result{#endsyntax#} and returns {#syntax#}true{#endsyntax#}.
8702-
If no overflow or underflow occurs, returns {#syntax#}false{#endsyntax#}.
8700+
Performs {#syntax#}a * b{#endsyntax#} and returns a tuple with the result and a possible overflow bit.
87038701
</p>
87048702
{#header_close#}
87058703

@@ -8973,15 +8971,13 @@ test "@setRuntimeSafety" {
89738971
{#header_close#}
89748972

89758973
{#header_open|@shlWithOverflow#}
8976-
<pre>{#syntax#}@shlWithOverflow(comptime T: type, a: T, shift_amt: Log2T, result: *T) bool{#endsyntax#}</pre>
8974+
<pre>{#syntax#}@shlWithOverflow(a: anytype, shift_amt: Log2T) struct { @TypeOf(a), u1 }{#endsyntax#}</pre>
89778975
<p>
8978-
Performs {#syntax#}result.* = a << b{#endsyntax#}. If overflow or underflow occurs,
8979-
stores the overflowed bits in {#syntax#}result{#endsyntax#} and returns {#syntax#}true{#endsyntax#}.
8980-
If no overflow or underflow occurs, returns {#syntax#}false{#endsyntax#}.
8976+
Performs {#syntax#}a << b{#endsyntax#} and returns a tuple with the result and a possible overflow bit.
89818977
</p>
89828978
<p>
8983-
The type of {#syntax#}shift_amt{#endsyntax#} is an unsigned integer with {#syntax#}log2(@typeInfo(T).Int.bits){#endsyntax#} bits.
8984-
This is because {#syntax#}shift_amt >= @typeInfo(T).Int.bits{#endsyntax#} is undefined behavior.
8979+
The type of {#syntax#}shift_amt{#endsyntax#} is an unsigned integer with {#syntax#}log2(@typeInfo(@TypeOf(a)).Int.bits){#endsyntax#} bits.
8980+
This is because {#syntax#}shift_amt >= @typeInfo(@TypeOf(a)).Int.bits{#endsyntax#} is undefined behavior.
89858981
</p>
89868982
{#see_also|@shlExact|@shrExact#}
89878983
{#header_close#}
@@ -9323,11 +9319,9 @@ fn doTheTest() !void {
93239319
{#header_close#}
93249320

93259321
{#header_open|@subWithOverflow#}
9326-
<pre>{#syntax#}@subWithOverflow(comptime T: type, a: T, b: T, result: *T) bool{#endsyntax#}</pre>
9322+
<pre>{#syntax#}@subWithOverflow(a: anytype, b: anytype) struct { @TypeOf(a, b), u1 }{#endsyntax#}</pre>
93279323
<p>
9328-
Performs {#syntax#}result.* = a - b{#endsyntax#}. If overflow or underflow occurs,
9329-
stores the overflowed bits in {#syntax#}result{#endsyntax#} and returns {#syntax#}true{#endsyntax#}.
9330-
If no overflow or underflow occurs, returns {#syntax#}false{#endsyntax#}.
9324+
Performs {#syntax#}a - b{#endsyntax#} and returns a tuple with the result and a possible overflow bit.
93319325
</p>
93329326
{#header_close#}
93339327

@@ -9774,11 +9768,11 @@ const print = @import("std").debug.print;
97749768
pub fn main() void {
97759769
var byte: u8 = 255;
97769770

9777-
var result: u8 = undefined;
9778-
if (@addWithOverflow(u8, byte, 10, &result)) {
9779-
print("overflowed result: {}\n", .{result});
9771+
const ov = @addWithOverflow(byte, 10);
9772+
if (ov[1] != 0) {
9773+
print("overflowed result: {}\n", .{ov[0]});
97809774
} else {
9781-
print("result: {}\n", .{result});
9775+
print("result: {}\n", .{ov[0]});
97829776
}
97839777
}
97849778
{#code_end#}

‎lib/compiler_rt/trunctfxf2.zig

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,14 +49,16 @@ pub fn __trunctfxf2(a: f128) callconv(.C) f80 {
4949
const round_bits = a_abs & round_mask;
5050
if (round_bits > halfway) {
5151
// Round to nearest
52-
const carry = @boolToInt(@addWithOverflow(u64, res.fraction, 1, &res.fraction));
53-
res.exp += carry;
54-
res.fraction |= @as(u64, carry) << 63; // Restore integer bit after carry
52+
const ov = @addWithOverflow(res.fraction, 1);
53+
res.fraction = ov[0];
54+
res.exp += ov[1];
55+
res.fraction |= @as(u64, ov[1]) << 63; // Restore integer bit after carry
5556
} else if (round_bits == halfway) {
5657
// Ties to even
57-
const carry = @boolToInt(@addWithOverflow(u64, res.fraction, res.fraction & 1, &res.fraction));
58-
res.exp += carry;
59-
res.fraction |= @as(u64, carry) << 63; // Restore integer bit after carry
58+
const ov = @addWithOverflow(res.fraction, res.fraction & 1);
59+
res.fraction = ov[0];
60+
res.exp += ov[1];
61+
res.fraction |= @as(u64, ov[1]) << 63; // Restore integer bit after carry
6062
}
6163
if (res.exp == 0) res.fraction &= ~@as(u64, integer_bit); // Remove integer bit for de-normals
6264
}

‎lib/std/compress/deflate/compressor_test.zig

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -172,9 +172,7 @@ test "deflate/inflate" {
172172
defer testing.allocator.free(large_data_chunk);
173173
// fill with random data
174174
for (large_data_chunk) |_, i| {
175-
var mul: u8 = @truncate(u8, i);
176-
_ = @mulWithOverflow(u8, mul, mul, &mul);
177-
large_data_chunk[i] = mul;
175+
large_data_chunk[i] = @truncate(u8, i) *% @truncate(u8, i);
178176
}
179177
try testToFromWithLimit(large_data_chunk, limits);
180178
}

‎lib/std/crypto/pcurves/p256/p256_64.zig

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,10 @@ pub const NonMontgomeryDomainFieldElement = [4]u64;
7575
inline fn addcarryxU64(out1: *u64, out2: *u1, arg1: u1, arg2: u64, arg3: u64) void {
7676
@setRuntimeSafety(mode == .Debug);
7777

78-
var t: u64 = undefined;
79-
const carry1 = @addWithOverflow(u64, arg2, arg3, &t);
80-
const carry2 = @addWithOverflow(u64, t, arg1, out1);
81-
out2.* = @boolToInt(carry1) | @boolToInt(carry2);
78+
const ov1 = @addWithOverflow(arg2, arg3);
79+
const ov2 = @addWithOverflow(ov1[0], arg1);
80+
out1.* = ov2[0];
81+
out2.* = ov1[1] | ov2[1];
8282
}
8383

8484
/// The function subborrowxU64 is a subtraction with borrow.
@@ -97,10 +97,10 @@ inline fn addcarryxU64(out1: *u64, out2: *u1, arg1: u1, arg2: u64, arg3: u64) vo
9797
inline fn subborrowxU64(out1: *u64, out2: *u1, arg1: u1, arg2: u64, arg3: u64) void {
9898
@setRuntimeSafety(mode == .Debug);
9999

100-
var t: u64 = undefined;
101-
const carry1 = @subWithOverflow(u64, arg2, arg3, &t);
102-
const carry2 = @subWithOverflow(u64, t, arg1, out1);
103-
out2.* = @boolToInt(carry1) | @boolToInt(carry2);
100+
const ov1 = @subWithOverflow(arg2, arg3);
101+
const ov2 = @subWithOverflow(ov1[0], arg1);
102+
out1.* = ov2[0];
103+
out2.* = ov1[1] | ov2[1];
104104
}
105105

106106
/// The function mulxU64 is a multiplication, returning the full double-width result.

‎lib/std/crypto/pcurves/p256/p256_scalar_64.zig

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,10 @@ pub const NonMontgomeryDomainFieldElement = [4]u64;
7575
inline fn addcarryxU64(out1: *u64, out2: *u1, arg1: u1, arg2: u64, arg3: u64) void {
7676
@setRuntimeSafety(mode == .Debug);
7777

78-
var t: u64 = undefined;
79-
const carry1 = @addWithOverflow(u64, arg2, arg3, &t);
80-
const carry2 = @addWithOverflow(u64, t, arg1, out1);
81-
out2.* = @boolToInt(carry1) | @boolToInt(carry2);
78+
const ov1 = @addWithOverflow(arg2, arg3);
79+
const ov2 = @addWithOverflow(ov1[0], arg1);
80+
out1.* = ov2[0];
81+
out2.* = ov1[1] | ov2[1];
8282
}
8383

8484
/// The function subborrowxU64 is a subtraction with borrow.
@@ -97,10 +97,10 @@ inline fn addcarryxU64(out1: *u64, out2: *u1, arg1: u1, arg2: u64, arg3: u64) vo
9797
inline fn subborrowxU64(out1: *u64, out2: *u1, arg1: u1, arg2: u64, arg3: u64) void {
9898
@setRuntimeSafety(mode == .Debug);
9999

100-
var t: u64 = undefined;
101-
const carry1 = @subWithOverflow(u64, arg2, arg3, &t);
102-
const carry2 = @subWithOverflow(u64, t, arg1, out1);
103-
out2.* = @boolToInt(carry1) | @boolToInt(carry2);
100+
const ov1 = @subWithOverflow(arg2, arg3);
101+
const ov2 = @subWithOverflow(ov1[0], arg1);
102+
out1.* = ov2[0];
103+
out2.* = ov1[1] | ov2[1];
104104
}
105105

106106
/// The function mulxU64 is a multiplication, returning the full double-width result.

‎lib/std/crypto/pcurves/p384/p384_64.zig

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@ pub const NonMontgomeryDomainFieldElement = [6]u64;
4444
inline fn addcarryxU64(out1: *u64, out2: *u1, arg1: u1, arg2: u64, arg3: u64) void {
4545
@setRuntimeSafety(mode == .Debug);
4646

47-
var t: u64 = undefined;
48-
const carry1 = @addWithOverflow(u64, arg2, arg3, &t);
49-
const carry2 = @addWithOverflow(u64, t, arg1, out1);
50-
out2.* = @boolToInt(carry1) | @boolToInt(carry2);
47+
const ov1 = @addWithOverflow(arg2, arg3);
48+
const ov2 = @addWithOverflow(ov1[0], arg1);
49+
out1.* = ov2[0];
50+
out2.* = ov1[1] | ov2[1];
5151
}
5252

5353
/// The function subborrowxU64 is a subtraction with borrow.
@@ -66,10 +66,10 @@ inline fn addcarryxU64(out1: *u64, out2: *u1, arg1: u1, arg2: u64, arg3: u64) vo
6666
inline fn subborrowxU64(out1: *u64, out2: *u1, arg1: u1, arg2: u64, arg3: u64) void {
6767
@setRuntimeSafety(mode == .Debug);
6868

69-
var t: u64 = undefined;
70-
const carry1 = @subWithOverflow(u64, arg2, arg3, &t);
71-
const carry2 = @subWithOverflow(u64, t, arg1, out1);
72-
out2.* = @boolToInt(carry1) | @boolToInt(carry2);
69+
const ov1 = @subWithOverflow(arg2, arg3);
70+
const ov2 = @subWithOverflow(ov1[0], arg1);
71+
out1.* = ov2[0];
72+
out2.* = ov1[1] | ov2[1];
7373
}
7474

7575
/// The function mulxU64 is a multiplication, returning the full double-width result.

‎lib/std/crypto/pcurves/p384/p384_scalar_64.zig

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@ pub const NonMontgomeryDomainFieldElement = [6]u64;
4444
inline fn addcarryxU64(out1: *u64, out2: *u1, arg1: u1, arg2: u64, arg3: u64) void {
4545
@setRuntimeSafety(mode == .Debug);
4646

47-
var t: u64 = undefined;
48-
const carry1 = @addWithOverflow(u64, arg2, arg3, &t);
49-
const carry2 = @addWithOverflow(u64, t, arg1, out1);
50-
out2.* = @boolToInt(carry1) | @boolToInt(carry2);
47+
const ov1 = @addWithOverflow(arg2, arg3);
48+
const ov2 = @addWithOverflow(ov1[0], arg1);
49+
out1.* = ov2[0];
50+
out2.* = ov1[1] | ov2[1];
5151
}
5252

5353
/// The function subborrowxU64 is a subtraction with borrow.
@@ -66,10 +66,10 @@ inline fn addcarryxU64(out1: *u64, out2: *u1, arg1: u1, arg2: u64, arg3: u64) vo
6666
inline fn subborrowxU64(out1: *u64, out2: *u1, arg1: u1, arg2: u64, arg3: u64) void {
6767
@setRuntimeSafety(mode == .Debug);
6868

69-
var t: u64 = undefined;
70-
const carry1 = @subWithOverflow(u64, arg2, arg3, &t);
71-
const carry2 = @subWithOverflow(u64, t, arg1, out1);
72-
out2.* = @boolToInt(carry1) | @boolToInt(carry2);
69+
const ov1 = @subWithOverflow(arg2, arg3);
70+
const ov2 = @subWithOverflow(ov1[0], arg1);
71+
out1.* = ov2[0];
72+
out2.* = ov1[1] | ov2[1];
7373
}
7474

7575
/// The function mulxU64 is a multiplication, returning the full double-width result.

‎lib/std/crypto/pcurves/secp256k1/secp256k1_64.zig

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@ pub const NonMontgomeryDomainFieldElement = [4]u64;
4444
inline fn addcarryxU64(out1: *u64, out2: *u1, arg1: u1, arg2: u64, arg3: u64) void {
4545
@setRuntimeSafety(mode == .Debug);
4646

47-
var t: u64 = undefined;
48-
const carry1 = @addWithOverflow(u64, arg2, arg3, &t);
49-
const carry2 = @addWithOverflow(u64, t, arg1, out1);
50-
out2.* = @boolToInt(carry1) | @boolToInt(carry2);
47+
const ov1 = @addWithOverflow(arg2, arg3);
48+
const ov2 = @addWithOverflow(ov1[0], arg1);
49+
out1.* = ov2[0];
50+
out2.* = ov1[1] | ov2[1];
5151
}
5252

5353
/// The function subborrowxU64 is a subtraction with borrow.
@@ -66,10 +66,10 @@ inline fn addcarryxU64(out1: *u64, out2: *u1, arg1: u1, arg2: u64, arg3: u64) vo
6666
inline fn subborrowxU64(out1: *u64, out2: *u1, arg1: u1, arg2: u64, arg3: u64) void {
6767
@setRuntimeSafety(mode == .Debug);
6868

69-
var t: u64 = undefined;
70-
const carry1 = @subWithOverflow(u64, arg2, arg3, &t);
71-
const carry2 = @subWithOverflow(u64, t, arg1, out1);
72-
out2.* = @boolToInt(carry1) | @boolToInt(carry2);
69+
const ov1 = @subWithOverflow(arg2, arg3);
70+
const ov2 = @subWithOverflow(ov1[0], arg1);
71+
out1.* = ov2[0];
72+
out2.* = ov1[1] | ov2[1];
7373
}
7474

7575
/// The function mulxU64 is a multiplication, returning the full double-width result.

‎lib/std/crypto/pcurves/secp256k1/secp256k1_scalar_64.zig

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@ pub const NonMontgomeryDomainFieldElement = [4]u64;
4444
inline fn addcarryxU64(out1: *u64, out2: *u1, arg1: u1, arg2: u64, arg3: u64) void {
4545
@setRuntimeSafety(mode == .Debug);
4646

47-
var t: u64 = undefined;
48-
const carry1 = @addWithOverflow(u64, arg2, arg3, &t);
49-
const carry2 = @addWithOverflow(u64, t, arg1, out1);
50-
out2.* = @boolToInt(carry1) | @boolToInt(carry2);
47+
const ov1 = @addWithOverflow(arg2, arg3);
48+
const ov2 = @addWithOverflow(ov1[0], arg1);
49+
out1.* = ov2[0];
50+
out2.* = ov1[1] | ov2[1];
5151
}
5252

5353
/// The function subborrowxU64 is a subtraction with borrow.
@@ -66,10 +66,10 @@ inline fn addcarryxU64(out1: *u64, out2: *u1, arg1: u1, arg2: u64, arg3: u64) vo
6666
inline fn subborrowxU64(out1: *u64, out2: *u1, arg1: u1, arg2: u64, arg3: u64) void {
6767
@setRuntimeSafety(mode == .Debug);
6868

69-
var t: u64 = undefined;
70-
const carry1 = @subWithOverflow(u64, arg2, arg3, &t);
71-
const carry2 = @subWithOverflow(u64, t, arg1, out1);
72-
out2.* = @boolToInt(carry1) | @boolToInt(carry2);
69+
const ov1 = @subWithOverflow(arg2, arg3);
70+
const ov2 = @subWithOverflow(ov1[0], arg1);
71+
out1.* = ov2[0];
72+
out2.* = ov1[1] | ov2[1];
7373
}
7474

7575
/// The function mulxU64 is a multiplication, returning the full double-width result.

‎lib/std/crypto/salsa20.zig

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,9 @@ fn SalsaNonVecImpl(comptime rounds: comptime_int) type {
263263
while (j < 64) : (j += 1) {
264264
xout[j] ^= buf[j];
265265
}
266-
ctx[9] += @boolToInt(@addWithOverflow(u32, ctx[8], 1, &ctx[8]));
266+
const ov = @addWithOverflow(ctx[8], 1);
267+
ctx[8] = ov[0];
268+
ctx[9] += ov[1];
267269
}
268270
if (i < in.len) {
269271
salsaCore(x[0..], ctx, true);

‎lib/std/crypto/utils.zig

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -87,15 +87,19 @@ pub fn timingSafeAdd(comptime T: type, a: []const T, b: []const T, result: []T,
8787
if (endian == .Little) {
8888
var i: usize = 0;
8989
while (i < len) : (i += 1) {
90-
const tmp = @boolToInt(@addWithOverflow(u8, a[i], b[i], &result[i]));
91-
carry = tmp | @boolToInt(@addWithOverflow(u8, result[i], carry, &result[i]));
90+
const ov1 = @addWithOverflow(a[i], b[i]);
91+
const ov2 = @addWithOverflow(ov1[0], carry);
92+
result[i] = ov2[0];
93+
carry = ov1[1] | ov2[1];
9294
}
9395
} else {
9496
var i: usize = len;
9597
while (i != 0) {
9698
i -= 1;
97-
const tmp = @boolToInt(@addWithOverflow(u8, a[i], b[i], &result[i]));
98-
carry = tmp | @boolToInt(@addWithOverflow(u8, result[i], carry, &result[i]));
99+
const ov1 = @addWithOverflow(a[i], b[i]);
100+
const ov2 = @addWithOverflow(ov1[0], carry);
101+
result[i] = ov2[0];
102+
carry = ov1[1] | ov2[1];
99103
}
100104
}
101105
return @bitCast(bool, carry);
@@ -110,15 +114,19 @@ pub fn timingSafeSub(comptime T: type, a: []const T, b: []const T, result: []T,
110114
if (endian == .Little) {
111115
var i: usize = 0;
112116
while (i < len) : (i += 1) {
113-
const tmp = @boolToInt(@subWithOverflow(u8, a[i], b[i], &result[i]));
114-
borrow = tmp | @boolToInt(@subWithOverflow(u8, result[i], borrow, &result[i]));
117+
const ov1 = @subWithOverflow(a[i], b[i]);
118+
const ov2 = @subWithOverflow(ov1[0], borrow);
119+
result[i] = ov2[0];
120+
borrow = ov1[1] | ov2[1];
115121
}
116122
} else {
117123
var i: usize = len;
118124
while (i != 0) {
119125
i -= 1;
120-
const tmp = @boolToInt(@subWithOverflow(u8, a[i], b[i], &result[i]));
121-
borrow = tmp | @boolToInt(@subWithOverflow(u8, result[i], borrow, &result[i]));
126+
const ov1 = @subWithOverflow(a[i], b[i]);
127+
const ov2 = @subWithOverflow(ov1[0], borrow);
128+
result[i] = ov2[0];
129+
borrow = ov1[1] | ov2[1];
122130
}
123131
}
124132
return @bitCast(bool, borrow);

0 commit comments

Comments
 (0)