From 344b38b3c0a26e0fe133c9a453a64999eab6f635 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Motiejus=20Jak=C5=A1tys?= <motiejus@uber.com>
Date: Thu, 20 Apr 2023 10:38:05 +0300
Subject: [PATCH] build: add BUILDMODE

We currently have 2 "popular" kinds of release modes:

- `ReleaseFast` without debug symbols. Existing behaviour, will be used
  to cut releases.
- `ReleaseSafe` with debug symbols. New behaviour, will be used for
  "new nightlies". See [ziglang/zig#15194][15194]

This script intends to be as prescriptive as possible, so we
specifically avoid other valid combinations (e.g. `ReleaseSmall`).
Therefore no such things like unvalidated "extra args" for zig.

If you want to add a new build mode and feel like a wide population
would benefit from it, submit a new issue and let's talk.

Example invocation:

    $ ./build x86_64-linux-gnu.2.28 baseline ReleaseSafeDbgSym
    Build configuration:
    Version:       0.11.0-dev.2680+a1aa55ebe
    Target:        x86_64-linux-gnu.2.28
    MCPU:          baseline
    Optimize:      ReleaseSafe
    Debug symbols: Yes

    <... build output ...>

[15194]: https://github.com/ziglang/zig/issues/15194
---
 build | 31 ++++++++++++++++++++++++++++++-
 1 file changed, 30 insertions(+), 1 deletion(-)

diff --git a/build b/build
index 71b49cf828..c10c2fc9d8 100755
--- a/build
+++ b/build
@@ -4,10 +4,39 @@ set -eu
 
 TARGET="$1" # Example: riscv64-linux-gnu
 MCPU="$2" # Examples: `baseline`, `native`, `generic+v7a`, or `arm1176jzf_s`
+BUILDMODE="$3" # Examples below
 
 ROOTDIR="$(pwd)"
 ZIG_VERSION="0.11.0-dev.2680+a1aa55ebe"
 
+case "$BUILDMODE" in
+    ReleaseSafeDbgSym)
+        OPTIMIZE=ReleaseSafe
+        DBGSYM=Yes
+        ZIG_STRIP=
+        ;;
+    ReleaseFastStrip)
+        OPTIMIZE=ReleaseFast
+        DBGSYM=No
+        ZIG_STRIP=-D
+        ;;
+    *)
+        >&2 printf "Unsupported build mode %s. Expecting %s or %s\n" \
+            "$BUILDMODE" ReleaseSafeDbgSym ReleaseFastStrip
+        exit 1
+        ;;
+esac
+
+cat <<EOF
+Build configuration:
+Version:       $ZIG_VERSION
+Target:        $TARGET
+MCPU:          $MCPU
+Optimize:      $OPTIMIZE
+Debug symbols: $DBGSYM
+
+EOF
+
 TARGET_OS_AND_ABI=${TARGET#*-} # Example: linux-gnu
 
 # Here we map the OS from the target triple to the value that CMake expects.
@@ -192,7 +221,7 @@ $ZIG build \
   --search-prefix "$ROOTDIR/out/$TARGET-$MCPU" \
   -Dstatic-llvm \
   -Doptimize=ReleaseFast \
-  -Dstrip \
+  $ZIG_STRIP \
   -Dtarget="$TARGET" \
   -Dcpu="$MCPU" \
   -Dversion-string="$ZIG_VERSION"