Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command arguments are not respected on Windows #63

Open
dsherret opened this issue Mar 27, 2023 · 2 comments
Open

Command arguments are not respected on Windows #63

dsherret opened this issue Mar 27, 2023 · 2 comments
Labels
question Further information is requested

Comments

@dsherret
Copy link

dsherret commented Mar 27, 2023

This will ignore the args in the std::process::Command:

let mut cmd = std::process::Command::new("some_command");
cmd.env("some", "value").args(&["arg1"]);
let p = expectrl::Session::spawn(cmd).unwrap();

This seems to be because conpty 0.3 does not do anything with the arguments (maybe I'm misreading the code though):

https://github.com/zhiburt/conpty/blob/de641e6cf33ad5176e6090318c4723716bdc964c/src/lib.rs#L270
https://github.com/zhiburt/conpty/blob/de641e6cf33ad5176e6090318c4723716bdc964c/src/lib.rs#L398C47-L437

@dsherret dsherret changed the title Command arguments are not respected Command arguments are not respected on Windows Mar 27, 2023
@zhiburt
Copy link
Owner

zhiburt commented Mar 28, 2023

So I bet you're right;
I believe it was fixed a few weeks ago, but not released yet.

I'll release it after #62

@zhiburt zhiburt added the question Further information is requested label Mar 29, 2023
@zhiburt
Copy link
Owner

zhiburt commented Mar 30, 2023

try a new version expectrl = 0.7, I believe it must be addressed here.

jwodder added a commit to jwodder/confab that referenced this issue Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants