Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setEncoding() doesn't exist in browser #6

Closed
richardolsson opened this issue Jul 11, 2015 · 0 comments
Closed

setEncoding() doesn't exist in browser #6

richardolsson opened this issue Jul 11, 2015 · 0 comments
Labels
bug

Comments

@richardolsson
Copy link
Member

The Browserify XHR implementation of Node's http module does not support the IncomingMessage.setEncoding() method. This is causing errors when the SDK is used in a browser. Ideally this should be fixed in Browserify, but until then lets just verify that the method exists before invoking it.

More information about the underlying issue can be found in browserify/http-browserify#21.
richardolsson added a commit that referenced this issue Jul 11, 2015
@richardolsson
0.1.1
9316e0c 
Fixes two critical bugs when the SDK runs in the browser, due to issues with
Browserify. See issues #5 and #6 on GitHub for details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@richardolsson