-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message card #82
Comments
Started on this today. Initial notes:
|
Yes, the first design has so low contrast on the identifier prefix that it is almost hidden. Figure 3 and 4 though has a darker grey for the default message. That was better at drawing attention to the default message, away from the identifier prefix. With your new design, the identifier draws more attention, away from the default message.
I agree but I think we are losing a nice aspect of the first design: the relation between the default message and the translation. In the first design, it's almost like a book with the default message on the left and the translation on the right. In the new design, the default message looks more like a title for the translation. |
Nice yeah gonna tidy up the colours to match the design closer.
Fixing this with spacing, no worries. |
This GIF gives a sense of the kind of space constraints this design needs to satisfy in practice as opposed to the relatively idealised conditions in the mockups. Note how few of the viewport widths shown here have enough space for feat.smartSearch.filters.journey.inputString's message ID and source text. There simply isn't enough horizontal space for the side-by-side layout even on smaller desktop-class viewports, let alone mobile devices. Coming back to this now:
The underlying problem here is the unlabeled input fields. I've alleviated it a little with some extra spacing, but unlabeled input fields are an accessibility fail, as well as a missed opportunity to make an app more self-documenting and approachable for its able bodied users. So I'm going to tweak this a little further, like so.
|
Description
A message card shows the the message ID, the original message, a text area with the translation, what parameters are available and last change.
Design Specification
Fig. 1: Message without changes. Does not have focus.
Fig. 2: Message with saved changes. Does not have focus.
Fig. 3: Message with unsaved changes. Does not have focus.
Fig. 4: Message with unsaved changes. Has focus.
When a card has focus or is hovered, it has an outline. When a card has focus, any parameters are shown.
The text was updated successfully, but these errors were encountered: