We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in file: webapp/src/RepoGit.ts a folder is created using fs.existsSync which is not recommended
webapp/src/RepoGit.ts
The text was updated successfully, but these errors were encountered:
Is this implemented? I checked and the only mkdir is using fsp and is within this function inside of RepoGit.ts
mkdir
fsp
RepoGit.ts
private static async clone(spConfig: ServerProjectConfig): Promise<void> { debug(`create directory: ${spConfig.repoPath} ...`); await fsp.mkdir(spConfig.repoPath, { recursive: true }); const git = new SimpleGitWrapper(spConfig.repoPath); debug(`Cloning repo: ${spConfig.repoPath} ...`); await git.clone(spConfig.cloneUrl, spConfig.repoPath); debug(`Cloned repo: ${spConfig.repoPath}`); debug(`Checkout base branch: ${spConfig.baseBranch} ...`); await git.checkout(spConfig.baseBranch); debug(`Checked out base branch: ${spConfig.baseBranch}`); }
Sorry, something went wrong.
Our use of existsSync is still there on
existsSync
lyra/webapp/src/RepoGit.ts
Line 47 in e9eff18
It is not exactly used to create a folder, but to avoid creating a new folder with clone, it a folder already exists.
clone
No branches or pull requests
in file:
webapp/src/RepoGit.ts
a folder is created using fs.existsSync which is not recommendedThe text was updated successfully, but these errors were encountered: