-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/137 playwright setup #138
base: main
Are you sure you want to change the base?
Conversation
This contains information on how to run different tests and add new tests for Lyra. | ||
|
||
We are using Playwright to test integration of features. | ||
Read the documentation at [playwright.dev/docs](https://playwright.dev/docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, the URL does not lead to any documentation.
Screencast.from.2024-10-27.10-10-49.webm
Let's update the URL to something that resolves in documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will change to correct URL
@@ -5,4 +5,5 @@ module.exports = { | |||
moduleNameMapper: { | |||
'@/(.*)': '<rootDir>/src/$1', | |||
}, | |||
modulePathIgnorePatterns: ['<rootDir>/integrationTesting'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modulePathIgnorePatterns
is for making modules non-require()-able in the test environment. Why do we want to do that?
https://jestjs.io/docs/configuration#modulepathignorepatterns-arraystring
If it is for ignoring Playwright tests, there is a testPathIgnorePatterns
that we can use: https://jestjs.io/docs/configuration#testpathignorepatterns-arraystring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You understood my intent correctly, It is to exclude integration test from running when running jest. :)
Updating this too.
"@playwright/test": "^1.48.2", | ||
"@types/node": "^22.8.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two new devDependencies
are what npm init playwright@latest
adds.
We already have a devDependency
on @types/node
declared in the root package so we do not need to add a new one here.
Lyra does not require Node 22 yet so we should not to update types to types for Node 22.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright! :)
Playwright Setup
Resolves #137