Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/137 playwright setup #138

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

a-jaxell
Copy link
Collaborator

Playwright Setup

  • Adds playwright with minimal config

Resolves #137

@WULCAN WULCAN self-assigned this Oct 27, 2024
This contains information on how to run different tests and add new tests for Lyra.

We are using Playwright to test integration of features.
Read the documentation at [playwright.dev/docs](https://playwright.dev/docs)
Copy link
Collaborator

@WULCAN WULCAN Oct 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the URL does not lead to any documentation.

Screencast.from.2024-10-27.10-10-49.webm

Let's update the URL to something that resolves in documentation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change to correct URL

@@ -5,4 +5,5 @@ module.exports = {
moduleNameMapper: {
'@/(.*)': '<rootDir>/src/$1',
},
modulePathIgnorePatterns: ['<rootDir>/integrationTesting'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulePathIgnorePatterns is for making modules non-require()-able in the test environment. Why do we want to do that?

https://jestjs.io/docs/configuration#modulepathignorepatterns-arraystring

If it is for ignoring Playwright tests, there is a testPathIgnorePatterns that we can use: https://jestjs.io/docs/configuration#testpathignorepatterns-arraystring

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You understood my intent correctly, It is to exclude integration test from running when running jest. :)

Updating this too.

Comment on lines +34 to +35
"@playwright/test": "^1.48.2",
"@types/node": "^22.8.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two new devDependencies are what npm init playwright@latest adds.

We already have a devDependency on @types/node declared in the root package so we do not need to add a new one here.

Lyra does not require Node 22 yet so we should not to update types to types for Node 22.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright! :)

webapp/playwright.config.ts Show resolved Hide resolved
webapp/playwright.config.ts Show resolved Hide resolved
webapp/playwright.config.ts Show resolved Hide resolved
webapp/.gitignore Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up Playwright with Lyra current structure
2 participants