Fix survey dropdown issue by using new version of common #289
Conversation
|
Nice work! I'm commenting here because this is the affected app, even if the change is in zetkin/zetkin-common#58. I'm wondering if this is the best solution, because of the issue that you've raised here (good work spotting that btw!).
An alternative solution that would not incur this issue would be to add a "null" option to the select box and always display it at the top, with a translated string along the lines of "Pick an option". That way, the default value (null/undefined) would show that "Pick an option" pseudo-option, forcing the caller to pick a real option, and thereby triggering the default behaviour of saving the survey only once the caller has interacted with it. What do you think about that? |
|
Superseded by #290 |
Resolve #288
Requires zetkin/zetkin-common#58
A potential issue is illustrated below. Even when not changing anything, the survey will be automatically selected. This may be a good thing in some cases, but it also means that all surveys with any select-type questions will be automatically ticked for submission if the survey has been opened.
Screencast.from.2023-05-25.16-53-53.webm