Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOCKET no longer defined since winsock2.h removed from zmq.h #233

Open
Dysl3xik opened this issue Feb 3, 2020 · 2 comments
Open

SOCKET no longer defined since winsock2.h removed from zmq.h #233

Dysl3xik opened this issue Feb 3, 2020 · 2 comments

Comments

@Dysl3xik
Copy link
Contributor

Dysl3xik commented Feb 3, 2020

If you try to build this library with a newer release of ZeroMQ, on a windows box, you get errors because SOCKET can't be resolved in compatability.h.

This was introduced in this merge I believe: zeromq/libzmq#3681

I will submit a PR that introduces the same fix into this code base as was proposed in that one.

@nilsmelchert
Copy link

Thanks for the PR in advance.
Did you manage to compile zmqpp on windows?

@Dysl3xik
Copy link
Contributor Author

It worked fine with my fix applied, I didn't re-pull after it was merged though, but I would assume it was fine and this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants