[Feature Request] enhance function's user parameter id, expected to be string | undefined

[cqh963852]

Is your feature request related to a problem? Please describe.

While using zenstack with next-auth@5. ts show me Type 'undefined' is not assignable to type 'string'.

I think in some scenarios, such as user registration, there is no user id at this time.

Describe the solution you'd like

remove the required props;

[ymc9]

Hi @cqh963852 , when the user id is not available, what's the expected authorization behavior that you desire? Usually people want to treat it as an anonymous user and if so, you can call enhance with undefined user object.

[cqh963852]

Hi @cqh963852 , when the user id is not available, what's the expected authorization behavior that you desire? Usually people want to treat it as an anonymous user and if so, you can call enhance with undefined user object.

Thanks for your reply. When the user is anonymous, the User object may not exist (undefined | null).

But currently if I pass a undefined user in the context parameter. ts will reports an error, undefined cannot be assigned to string.

let user: {id:string}|undefined

// this will give an ts error.
enhace(prisma,{user})

[ymc9]

This is unexpected because the enhance API should always allow user to be undefined.

What version of ZenStack are you on? Do you have a sharable project?

[cqh963852]

This is unexpected because the enhance API should always allow user to be undefined.

What version of ZenStack are you on? Do you have a sharable project?

Sorry I got that wrong earlier.

The enhance can accept a undefined user.

but it requires user's id not be undefined.

The default user id of next-auth may be undefined.

I have also tried rewriting the interface. Since the interface follows the merge, there is no way to change id string | undefined to string

[ymc9]

This is unexpected because the enhance API should always allow user to be undefined.
What version of ZenStack are you on? Do you have a sharable project?

Sorry I got that wrong earlier.

The enhance can accept a undefined user.

but it requires user's id not be undefined.

The default user id of next-auth may be undefined.

I have also tried rewriting the interface. Since the interface follows the merge, there is no way to change id string | undefined to string

Got it. The current design of zenstack requires when a user context is provided, it must have a non-nullish id. You'll need to detect the next-auth's case and turn the entire user object to undefined if the id is not available.