Better assertions

assertIsArray instead of assertInternalType

Author: michalbundyra

test/Generator/PropertyGeneratorTest.php

@@ -262,7 +262,7 @@ public function testPropertyDocBlockWillLoadFromReflection() : void
         $docBlock = $cgProp->getDocBlock();
         self::assertInstanceOf(DocBlockGenerator::class, $docBlock);
         $tags     = $docBlock->getTags();
-        self::assertInternalType('array', $tags);
+        self::assertIsArray($tags);
         self::assertCount(1, $tags);
         $tag = array_shift($tags);
         self::assertInstanceOf(VarTag::class, $tag);

test/Reflection/ClassReflectionTest.php

@@ -203,13 +203,13 @@ public function testGetTraits()
 
         $reflectionClass = new ClassReflection(TestAsset\TestTraitClass4::class);
         $traitsArray = $reflectionClass->getTraits();
-        self::assertInternalType('array', $traitsArray);
+        self::assertIsArray($traitsArray);
         self::assertCount(1, $traitsArray);
         self::assertInstanceOf(ClassReflection::class, $traitsArray[0]);
 
         $reflectionClass = new ClassReflection(TestAsset\TestSampleClass::class);
         $traitsArray = $reflectionClass->getTraits();
-        self::assertInternalType('array', $traitsArray);
+        self::assertIsArray($traitsArray);
         self::assertCount(0, $traitsArray);
     }
 }

test/Scanner/ClassScannerTest.php

@@ -63,15 +63,15 @@ public function testClassScannerHasClassInformation()
         self::assertContains('A\B\C\D\Blarg', $interfaces);
         self::assertContains('ZendTest\Code\TestAsset\Local\SubClass', $interfaces);
         $methods = $class->getMethodNames();
-        self::assertInternalType('array', $methods);
+        self::assertIsArray($methods);
         self::assertContains('fooBarBaz', $methods);
     }
 
     public function testClassScannerHasConstant()
     {
         $file  = new FileScanner(__DIR__ . '/../TestAsset/FooClass.php');
         $class = $file->getClass(FooClass::class);
-        self::assertInternalType('array', $class->getConstantNames());
+        self::assertIsArray($class->getConstantNames());
         self::assertContains('FOO', $class->getConstantNames());
     }
 

test/Scanner/MethodScannerTest.php

@@ -39,7 +39,7 @@ public function testMethodScannerReturnsParameters()
         $class      = $file->getClass(BarClass::class);
         $method     = $class->getMethod('three');
         $parameters = $method->getParameters();
-        self::assertInternalType('array', $parameters);
+        self::assertIsArray($parameters);
     }
 
     public function testMethodScannerReturnsParameterScanner()

test/Scanner/TokenArrayScannerTest.php

@@ -28,7 +28,7 @@ public function testScannerReturnsNamespaces()
         ));
         self::assertTrue($tokenScanner->hasNamespace('ZendTest\Code\TestAsset'));
         $namespaces = $tokenScanner->getNamespaces();
-        self::assertInternalType('array', $namespaces);
+        self::assertIsArray($namespaces);
         self::assertContains('ZendTest\Code\TestAsset', $namespaces);
     }
 
@@ -38,7 +38,7 @@ public function testScannerReturnsNamespacesInNotNamespacedClasses()
             file_get_contents(__DIR__ . '/../TestAsset/FooBarClass.php')
         ));
         $uses = $tokenScanner->getUses();
-        self::assertInternalType('array', $uses);
+        self::assertIsArray($uses);
         $foundUses = [];
         foreach ($uses as $use) {
             $foundUses[] = $use['use'];
@@ -52,7 +52,7 @@ public function testScannerReturnsClassNames()
             file_get_contents(__DIR__ . '/../TestAsset/FooClass.php')
         ));
         $classes = $tokenScanner->getClassNames();
-        self::assertInternalType('array', $classes);
+        self::assertIsArray($classes);
         self::assertContains(FooClass::class, $classes);
     }
 
@@ -65,7 +65,7 @@ public function testScannerReturnsClassNamesForTraits()
             file_get_contents(__DIR__ . '/../TestAsset/FooTrait.php')
         ));
         $classes = $tokenScanner->getClassNames();
-        self::assertInternalType('array', $classes);
+        self::assertIsArray($classes);
         self::assertContains(FooTrait::class, $classes);
     }
 
@@ -75,7 +75,7 @@ public function testScannerReturnsFunctions()
             file_get_contents(__DIR__ . '/../TestAsset/functions.php')
         ));
         $functions = $tokenScanner->getFunctionNames();
-        self::assertInternalType('array', $functions);
+        self::assertIsArray($functions);
         self::assertContains('ZendTest\Code\TestAsset\foo_bar', $functions);
     }
 
@@ -85,7 +85,7 @@ public function testScannerReturnsClassScanner()
             file_get_contents(__DIR__ . '/../TestAsset/FooClass.php')
         ));
         $classes = $tokenScanner->getClasses();
-        self::assertInternalType('array', $classes);
+        self::assertIsArray($classes);
         foreach ($classes as $class) {
             self::assertInstanceOf(ClassScanner::class, $class);
         }