Fix bookmarks toolbar flickering on toggle #11540
Open
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
Contributor
Author
|
Sorry for the previous PR. I was trying to create a draft at the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the behavior of the bookmarks toolbar flickering when being toggled. The bug is tied to styles being unloaded while the topbar is fully hidden.
My changes will keep the topbar technically unhidden and styles loaded, but also unhoverable unless the bookmarks toolbar is toggled on. It should be visually indistinguishable from the current build.
If there are other cases where the topbar should be hoverable in sidebar-only mode, please let me know. I also have only tested this on Mac. Other platforms may have different behavior.
Fixes #11244