diff --git a/crates/language/src/buffer.rs b/crates/language/src/buffer.rs index 1605eea051b660..14e835cc37680b 100644 --- a/crates/language/src/buffer.rs +++ b/crates/language/src/buffer.rs @@ -3348,7 +3348,17 @@ impl BufferSnapshot { pub fn syntax_layer_at(&self, position: D) -> Option> { let offset = position.to_offset(self); self.syntax_layers_for_range(offset..offset, false) - .filter(|l| l.node().end_byte() > offset) + .filter(|l| { + if let Some(ranges) = l.included_sub_ranges { + ranges.iter().any(|range| { + let start = range.start.to_offset(self); + let end = range.end.to_offset(self); + start <= offset && offset < end + }) + } else { + l.node().start_byte() <= offset && l.node().end_byte() > offset + } + }) .last() } diff --git a/crates/language/src/buffer_tests.rs b/crates/language/src/buffer_tests.rs index 0e23a69f075fc3..ee04e0bd6e2e0d 100644 --- a/crates/language/src/buffer_tests.rs +++ b/crates/language/src/buffer_tests.rs @@ -2627,7 +2627,7 @@ fn test_language_scope_at_with_combined_injections(cx: &mut App) { buffer.set_language_registry(language_registry.clone()); buffer.set_language( language_registry - .language_for_name("ERB") + .language_for_name("HTML+ERB") .now_or_never() .unwrap() .ok(), @@ -2747,6 +2747,50 @@ fn test_language_at_for_markdown_code_block(cx: &mut App) { }); } +#[gpui::test] +fn test_syntax_layer_at_for_injected_languages(cx: &mut App) { + init_settings(cx, |_| {}); + + cx.new(|cx| { + let text = r#" + ```html+erb +
Hello
+ <%= link_to "Some", "https://zed.dev" %> + ``` + "# + .unindent(); + + let language_registry = Arc::new(LanguageRegistry::test(cx.background_executor().clone())); + language_registry.add(Arc::new(erb_lang())); + language_registry.add(Arc::new(html_lang())); + language_registry.add(Arc::new(ruby_lang())); + + let mut buffer = Buffer::local(text, cx); + buffer.set_language_registry(language_registry.clone()); + buffer.set_language( + language_registry + .language_for_name("HTML+ERB") + .now_or_never() + .unwrap() + .ok(), + cx, + ); + + let snapshot = buffer.snapshot(); + + // Test points in the code line + let html_point = Point::new(1, 4); + let language = snapshot.language_at(html_point).unwrap(); + assert_eq!(language.name().as_ref(), "HTML"); + + let ruby_point = Point::new(2, 6); + let language = snapshot.language_at(ruby_point).unwrap(); + assert_eq!(language.name().as_ref(), "Ruby"); + + buffer + }); +} + #[gpui::test] fn test_serialization(cx: &mut gpui::App) { let mut now = Instant::now(); @@ -3636,7 +3680,7 @@ fn html_lang() -> Language { fn erb_lang() -> Language { Language::new( LanguageConfig { - name: "ERB".into(), + name: "HTML+ERB".into(), matcher: LanguageMatcher { path_suffixes: vec!["erb".to_string()], ..Default::default() @@ -3654,15 +3698,15 @@ fn erb_lang() -> Language { .with_injection_query( r#" ( - (code) @injection.content - (#set! injection.language "ruby") - (#set! injection.combined) + (code) @content + (#set! "language" "ruby") + (#set! "combined") ) ( - (content) @injection.content - (#set! injection.language "html") - (#set! injection.combined) + (content) @content + (#set! "language" "html") + (#set! "combined") ) "#, ) diff --git a/crates/language/src/syntax_map.rs b/crates/language/src/syntax_map.rs index 528b25d47193eb..a9ac2faad9da9d 100644 --- a/crates/language/src/syntax_map.rs +++ b/crates/language/src/syntax_map.rs @@ -587,6 +587,8 @@ impl SyntaxSnapshot { let changed_ranges; let mut included_ranges = step.included_ranges; + let is_combined = matches!(step.mode, ParseMode::Combined { .. }); + for range in &mut included_ranges { range.start_byte -= step_start_byte; range.end_byte -= step_start_byte; @@ -749,16 +751,20 @@ impl SyntaxSnapshot { ); } - let included_sub_ranges: Option>> = - (included_ranges.len() > 1).then_some( + let included_sub_ranges: Option>> = if is_combined { + Some( included_ranges .into_iter() + .filter(|r| r.start_byte < r.end_byte) .map(|r| { text.anchor_before(r.start_byte + step_start_byte) ..text.anchor_after(r.end_byte + step_start_byte) }) .collect(), - ); + ) + } else { + None + }; SyntaxLayerContent::Parsed { tree, language,