Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let's don't generate exception if required capabilities not present #125

Open
vdelendik opened this issue Nov 14, 2023 · 1 comment
Open
Labels
enhancement New feature or request
Milestone

Comments

@vdelendik
Copy link
Contributor

# As a boolean, maps to "throwOnCapabilityNotPresent"
ENV GRID_THROW_ON_CAPABILITY_NOT_PRESENT true

In new approach with smart queue it has sense to keep requests even if required capability not present.
One more benefit of this approach is that we can start thinking about dynamic devices approach 9externl hub providers, aws or emulators etc)

During the testing we have understand what's going on and what's exception is returned after GRID_NEW_SESSION_WAIT_TIMEOUT=30000

it suppose to be error about node available....

@vdelendik vdelendik added the enhancement New feature or request label Nov 14, 2023
@vdelendik vdelendik added this to the 2.4 milestone Nov 14, 2023
@vdelendik
Copy link
Contributor Author

it has sense to test on production environments first this idea. Globally we wanna to achieve more stability even if any unique devices agents/nodes are corrupted. In this case sessions will be in queue until node is recovered, scaling env scaled or timeout for the job achieved... moving to 2.5 milestone as we'll adjust several prod envs to test on real use-cases first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants