diff --git a/docs/release.rst b/docs/release.rst index bda2f867..3638584b 100644 --- a/docs/release.rst +++ b/docs/release.rst @@ -38,6 +38,9 @@ Fixes * Add ``#ifndef`` guard around ``PyBytes_RESIZE``. By :user:`John Kirkham `, :issue:`732` +* Remove ``typesize`` from ``Blosc.get_config`` output + By :user:`Ilan Gold ` + Maintenance ~~~~~~~~~~~ diff --git a/numcodecs/blosc.pyx b/numcodecs/blosc.pyx index 6ec72e21..ddc29e1a 100644 --- a/numcodecs/blosc.pyx +++ b/numcodecs/blosc.pyx @@ -489,11 +489,11 @@ class Blosc(Codec): self.clevel = clevel self.shuffle = shuffle self.blocksize = blocksize - self.typesize = typesize + self._typesize = typesize def encode(self, buf): buf = ensure_contiguous_ndarray(buf, self.max_buffer_size) - return compress(buf, self._cname_bytes, self.clevel, self.shuffle, self.blocksize, self.typesize) + return compress(buf, self._cname_bytes, self.clevel, self.shuffle, self.blocksize, self._typesize) def decode(self, buf, out=None): buf = ensure_contiguous_ndarray(buf, self.max_buffer_size) diff --git a/numcodecs/tests/test_blosc.py b/numcodecs/tests/test_blosc.py index 81725018..52ef183a 100644 --- a/numcodecs/tests/test_blosc.py +++ b/numcodecs/tests/test_blosc.py @@ -278,7 +278,13 @@ def test_typesize_less_than_1(): Blosc(shuffle=Blosc.SHUFFLE, typesize=0) compressor = Blosc(shuffle=Blosc.SHUFFLE) # not really something that should be done in practice, but good for testing. - compressor.typesize = 0 + compressor._typesize = 0 arr = np.arange(100) with pytest.raises(ValueError, match=r"Cannot use typesize"): compressor.encode(arr.tobytes()) + + +def test_config_no_typesize(): + codec = Blosc(shuffle=Blosc.SHUFFLE, typesize=5) + config = codec.get_config() + assert "typesize" not in config