Skip to content

Explicitly pytest.skip any tests that depend on optional dependencies #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dstansby opened this issue Nov 15, 2024 · 0 comments · May be fixed by #740
Open

Explicitly pytest.skip any tests that depend on optional dependencies #640

dstansby opened this issue Nov 15, 2024 · 0 comments · May be fixed by #740

Comments

@dstansby
Copy link
Contributor

As a quick fix in #637, some tests for the CRC32C codec are only ever defined if crc32c is installed. If crc32c isn't installed, these tests are silently not defined or reported to pytest.

In order to report that these tests are being skipped to pytest, it would be much better to mark them with a pytest skip mark, so when the dependency isn't installed these skipped tests get reported to pytest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use pytest.skipif to properly report skipped CRC32C codec tests agriyakhetarpal/numcodecs
1 participant
@dstansby