Addresses feedback

wassafshahzad · wassafshahzad · commit 9d3d626ec840 · 2025-02-08T21:24:46.000+01:00
Signed-off-by: wassafshahzad &lt;wassafshahzad@gmail.com&gt;
diff --git a/filters/auth/oidc_introspection.go b/filters/auth/oidc_introspection.go
@@ -141,7 +141,7 @@ func (filter *oidcIntrospectionFilter) Request(ctx filters.FilterContext) {
 
 	sub, ok := token.Claims["sub"].(string)
 	if !ok {
-		unauthorized(ctx, sub, invalidSub, "", "")
+		unauthorized(ctx, r.Host, invalidSub, "", "")
 		return
 	}
 
diff --git a/filters/auth/oidc_introspection_test.go b/filters/auth/oidc_introspection_test.go
@@ -167,7 +167,7 @@ func TestOIDCQueryClaimsFilter(t *testing.T) {
 			expectErr: false,
 		},
 		{
-			msg: "secure sub/path is not permitted",
+			msg: "missing sub claim is not permitted",
 			args: []interface{}{
 				"/login:groups.#[==\"AppX-Test-Users\"]",
 				"/:@_:email%\"*@example.org\"",

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ func (filter *oidcIntrospectionFilter) Request(ctx filters.FilterContext) {`
`141`	`141`
`142`	`142`	`sub, ok := token.Claims["sub"].(string)`
`143`	`143`	`if !ok {`
`144`		`- unauthorized(ctx, sub, invalidSub, "", "")`
	`144`	`+ unauthorized(ctx, r.Host, invalidSub, "", "")`
`145`	`145`	`return`
`146`	`146`	`}`
`147`	`147`
Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,7 @@ func TestOIDCQueryClaimsFilter(t *testing.T) {`
`167`	`167`	`expectErr: false,`
`168`	`168`	`},`
`169`	`169`	`{`
`170`		`- msg: "secure sub/path is not permitted",`
	`170`	`+ msg: "missing sub claim is not permitted",`
`171`	`171`	`args: []interface{}{`
`172`	`172`	`"/login:groups.#[==\"AppX-Test-Users\"]",`
`173`	`173`	`"/:@_:email%\"*@example.org\"",`