support wildcard for the first segment only in ingress

Signed-off-by: Mustafa Abdelrahman <[email protected]>

Author: MustafaSaber

dataclients/kubernetes/hosts.go

@@ -15,6 +15,9 @@ func createHostRx(hosts ...string) string {
 
 	hrx := make([]string, len(hosts))
 	for i, host := range hosts {
+		if strings.HasPrefix(host, "*.") {
+			host = strings.Replace(host, "*", "[a-z0-9]+(-[a-z0-9]+)?", 1)
+		}
 		// trailing dots and port are not allowed in kube
 		// ingress spec, so we can append optional setting
 		// without check

dataclients/kubernetes/hosts_test.go

@@ -1,7 +1,6 @@
 package kubernetes
 
 import (
-	"regexp"
 	"testing"
 
 	"github.com/stretchr/testify/require"
@@ -21,15 +20,12 @@ func TestHostsToRegex(t *testing.T) {
 		{
 			msg:   "wildcard",
 			host:  "*.example.org",
-			regex: "^(*[.]example[.]org[.]?(:[0-9]+)?)$",
+			regex: "^([a-z0-9]+(-[a-z0-9]+)?[.]example[.]org[.]?(:[0-9]+)?)$",
 		},
 	} {
 		t.Run(ti.msg, func(t *testing.T) {
 			regex := createHostRx(ti.host)
 			require.Equal(t, ti.regex, regex)
-			// maybe we should validate the generated regex and maybe add
-			_, err := regexp.Compile(regex)
-			require.NoError(t, err)
 		})
 	}
 }

dataclients/kubernetes/testdata/ingressV1/ingress-data/wildcard-ing-prefix.eskip

@@ -1,3 +1,3 @@
 kube_foo__qux____example_org_____qux:
-	Host("^(*[.]example[.]org[.]?(:[0-9]+)?)$") && PathSubtree("/")
+	Host("^([a-z0-9]+(-[a-z0-9]+)?[.]example[.]org[.]?(:[0-9]+)?)$") && PathSubtree("/")
 	-> <roundRobin, "http://10.2.9.103:8080", "http://10.2.9.104:8080">;

predicates/forwarded/forwarded_test.go

@@ -164,7 +164,7 @@ func TestForwardedHost(t *testing.T) {
 		isError: false,
 	}, {
 		msg:  "wildcard host should match",
-		host: "^(*[.]example[.]org[.]?(:[0-9]+)?)$", // *.example.org
+		host: "^([a-z0-9]+(-[a-z0-9]+)?[.]example[.]org[.]?(:[0-9]+)?)$", // *.example.org
 		r: request{
 			url: "https://test.example.com/index.html",
 			headers: http.Header{
@@ -173,6 +173,28 @@ func TestForwardedHost(t *testing.T) {
 		},
 		matches: true,
 		isError: false,
+	}, {
+		msg:  "wildcard 2 host should match",
+		host: "^([a-z0-9]+(-[a-z0-9]+)?[.]example[.]org[.]?(:[0-9]+)?)$", // *.example.org
+		r: request{
+			url: "https://test-v2.example.com/index.html",
+			headers: http.Header{
+				"Forwarded": []string{`host="test-v2.example.org"`},
+			},
+		},
+		matches: true,
+		isError: false,
+	}, {
+		msg:  "wildcard 3 host shouldn't match",
+		host: "^([a-z0-9]+(-[a-z0-9]+)?[.]example[.]org[.]?(:[0-9]+)?)$", // *.example.org
+		r: request{
+			url: "https://test-.example.com/index.html",
+			headers: http.Header{
+				"Forwarded": []string{`host="test-.example.com"`},
+			},
+		},
+		matches: false,
+		isError: false,
 	}}
 
 	for _, tc := range testCases {