New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use blueprint class names safely #803

Closed

stropitek opened this issue Dec 6, 2024 · 2 comments · Fixed by #847

Assignees

Contributor

stropitek commented Dec 6, 2024

Change hardcoded usage of bp5-* in CSS to ${Classes.XXX}

Example:

react-science/src/components/dialog/ConfirmDialog.tsx

Line 35 in bb5a82d

.bp5-dialog-header {

When doing so, you can change also refactor to use styled components rather than passing a css prop.

The text was updated successfully, but these errors were encountered:

stropitek assigned Sebastien-Ahkrin

Member

targos commented Dec 6, 2024

Aren't blueprint class names generally deprecated?

Contributor Author

stropitek commented Dec 6, 2024

They are not really deprecated, but it is discouraged to use them, because they can change.

In cases when we can avoid to use them we should not use them (some examples are documented in the official documentation).

We use them mostly to override the style of some markup internal to the component that would not be easy to change otherwise. By importing them we at least will have an error if the class no longer exists.

Sebastien-Ahkrin added a commit that referenced this issue


          refactor: use blueprint classnames safely

4d94d9e

Closes: #803

Sebastien-Ahkrin linked a pull request

that will close this issue

refactor: use blueprint classnames safely #847

Merged

Sebastien-Ahkrin closed this as completed in #847

Sebastien-Ahkrin closed this as completed in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment