Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with FunctionSeries and padding #333

Closed
wadjih-bencheikh18 opened this issue Feb 13, 2022 · 5 comments
Closed

Problem with FunctionSeries and padding #333

wadjih-bencheikh18 opened this issue Feb 13, 2022 · 5 comments
Assignees
Labels

Comments

@wadjih-bencheikh18
Copy link
Contributor

https://zakodium.github.io/react-plot/?path=/story/examples-iris-dataset--pca
when we add padding in x Axis the plot will start zoom out

@targos
Copy link
Member

targos commented Feb 14, 2022

I don't understand what's the bug?

@wadjih-bencheikh18
Copy link
Contributor Author

when we add padding to x axis
functionSeries start from min-padding so this last will be the new min ...etc

Iris.dataset.story.bug_Trim.mp4

@wadjih-bencheikh18
Copy link
Contributor Author

i think we should force function serie to not change Axis min/max (because we're using LineSeries)

@targos targos added the discuss label Feb 15, 2022
@lpatiny lpatiny changed the title Iris dataset story bug Padding should only be used when min and / or max are undefined Feb 17, 2022
@targos targos changed the title Padding should only be used when min and / or max are undefined Problem with FunctionSeries and padding Feb 19, 2022
@targos
Copy link
Member

targos commented Feb 19, 2022

Padding should only be used when min and / or max are undefined

This is implemented in 4664c20.

But we still have an issue with FunctionSeries because it is possible to render one without specifying min/max on the axis (for example when there are other series in the plot). In that case, and when there is padding, the LineSeries rendered internally by FunctionSeries will increase the automatic boundaries and we end up with the infinite loop.

I'm going to implement #316 (comment) first and this should either be fixed as a result, or easy to fix afterwards.

@wadjih-bencheikh18
Copy link
Contributor Author

@targos issue fixed

@targos targos closed this as completed Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants