-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with FunctionSeries and padding #333
Comments
I don't understand what's the bug? |
when we add padding to x axis Iris.dataset.story.bug_Trim.mp4 |
i think we should force function serie to not change Axis min/max (because we're using LineSeries) |
This is implemented in 4664c20. But we still have an issue with FunctionSeries because it is possible to render one without specifying min/max on the axis (for example when there are other series in the plot). In that case, and when there is padding, the LineSeries rendered internally by FunctionSeries will increase the automatic boundaries and we end up with the infinite loop. I'm going to implement #316 (comment) first and this should either be fixed as a result, or easy to fix afterwards. |
@targos issue fixed |
https://zakodium.github.io/react-plot/?path=/story/examples-iris-dataset--pca
when we add padding in x Axis the plot will start zoom out
The text was updated successfully, but these errors were encountered: