Skip to content

Commit 738e2fe

Browse files
fix: do not prevent triggering onChange when props are changed (#23)
1 parent 1199c25 commit 738e2fe

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

src/components/StructureEditor.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ function StructureEditor(props) {
4040
}
4141
}
4242

43-
editorRef.current = { editor, hadFirstChange: false };
43+
editorRef.current.editor = editor;
4444
if (initialMolfile && initialIDCode) {
4545
throw new Error('Cannot specify both initialMolfile and initialIDCode');
4646
}

stories/structure-editor.stories.js

+6-4
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ export default {
88
args: {
99
svgMenu: true,
1010
fragment: false,
11+
width: 675,
12+
height: 450,
1113
},
1214
parameters: {
1315
docs: {
@@ -38,7 +40,7 @@ Actelion Java MolfileCreator 1.0
3840
M END
3941
`;
4042

41-
export function FromMolfile({ svgMenu, fragment }) {
43+
export function FromMolfile({ svgMenu, fragment, width, height }) {
4244
const [molfile, setMolfile] = useState(initialMolfile);
4345
const [previous, setPrevious] = useState(null);
4446
const cb = useCallback(
@@ -53,7 +55,7 @@ export function FromMolfile({ svgMenu, fragment }) {
5355
<h2>Editor</h2>
5456
<StructureEditor
5557
initialMolfile={molfile}
56-
svgMenu={svgMenu}
58+
{...{ svgMenu, width, height }}
5759
fragment={fragment}
5860
onChange={cb}
5961
/>
@@ -71,7 +73,7 @@ export function FromMolfile({ svgMenu, fragment }) {
7173
);
7274
}
7375

74-
export function FromIDCode({ svgMenu, fragment }) {
76+
export function FromIDCode({ svgMenu, fragment, width, height }) {
7577
const [idCode, setIDCode] = useState(initialIDCode);
7678
const [previous, setPrevious] = useState(null);
7779
const cb = useCallback(
@@ -86,7 +88,7 @@ export function FromIDCode({ svgMenu, fragment }) {
8688
<h2>Editor</h2>
8789
<StructureEditor
8890
initialIDCode={idCode}
89-
svgMenu={svgMenu}
91+
{...{ svgMenu, width, height }}
9092
fragment={fragment}
9193
onChange={cb}
9294
/>

0 commit comments

Comments
 (0)