Skip to content
This repository was archived by the owner on Apr 1, 2020. It is now read-only.

Show a proper error in a commit message with a colon #11

Closed
ajsb85 opened this issue Apr 3, 2018 · 5 comments
Closed

Show a proper error in a commit message with a colon #11

ajsb85 opened this issue Apr 3, 2018 · 5 comments

Comments

@ajsb85
Copy link

ajsb85 commented Apr 3, 2018

Hi, @ahmed-taj

Take a look in this error msg.

image

image

Reference:
flyve-mdm/glpi-plugin#386

@ajsb85
Copy link
Author

ajsb85 commented Apr 5, 2018

Hi, @ahmed-taj
We fix the the commit message but...
Multiples messages from the bot:
flyve-mdm/glpi-plugin#386 (comment)

@z0al
Copy link
Owner

z0al commented Apr 5, 2018

Hey @ajsb85 sorry about that :/

I will try track this down and see what I can do. Also, it might be related to commitlint library itself @marionebl ?

Multiples messages from the bot

The bot posts a single comment for every check. That isn't perfect of course but was initially a workaround not having a server side storage mechanism for reports.

I think I should change the app to modify existing comment instead of creating new one.

@ajsb85
Copy link
Author

ajsb85 commented Apr 5, 2018

Hi, @btry

Could you validate if this CLI Tool show the same issue?
https://github.com/marionebl/commitlint

@suriyaa
Copy link

suriyaa commented Apr 15, 2018

@ahmed-taj Same error at suriyaa/awesome-mozilla#4.

Error notification and status was trigged by @commitlint bot because I used emojis in the commit message.

@z0al
Copy link
Owner

z0al commented Jul 8, 2018

This should be fixed by #12 . Please feel free to reopen if it's there

@z0al z0al closed this as completed Jul 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants