Skip to content

Incorrect URL for repository if base path ends with '\' #5

Description

@ivan-danilov

At this line you are assuming that basePath does not have backslash ('') in the end and FullName has. While the latter is correct because there's some non-empty relative path after base path, former is incorrect because user can enter any string she wants.

As the result if basePath has backslash at its end, user would see first char cut. For example if repository is abc.git, user will see URL 'http://localhost/bc.git' which is incorrect.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions