PSTV Controller Support

[TheThomasD]

Is your feature request related to a problem? Please describe.
Yes, I cannot use the PS3/PS4 controller keys (e.g. PS Button or R1/R2/R3) currently.

Describe the solution you'd like
Key mapping for PS3/PS4 controllers connected to a PSTV (so I can use my PSTV similarly to PS4 remote play, but with the PS5)

Describe alternatives you've considered
I own a PS Vita as well, but using the PSTVs I have spread over my home would be more convenient (e.g. bigger screen, better controller).

Additional context
I can run the application successfully on a PSTV and connect to the PS5 system. However, I cannot use the PS button and all of R1/R2/R3 (same for L and potentially touch on a PS4 controller, but haven't tried yet).

I have some experience in programming and am willing to support here, but I think I need some info on how to approach the issue. I guess the controller.c/.h files as well as host.c will be involved in a fix. If I can get some basic info on how to do this, I will give it a try.

THANK YOU FOR THE AWESOME WORK!

[ywnico]

Good point, I completely forgot about the PSTV!

I'm not sure if I can get around to it before February, so it would be great if you want to take a crack at it!

First, I should apologize for my confusing code...I'll have to refactor controller.c and host.c... -_-

Basically, controller.c is just some ugly logic to handle different control mappings, and the actual process of interpreting input and sending the right output to chiaki is done in host.c (I should really move this to controller.c). The thing that makes it slightly annoying is that all buttons are bitwise flags on Chiaki's internal state (stream->controller_state.buttons) except L2/R2, which are sent in a different way. Idk why, that's just how the Chiaki internals are.

Anyway, there should be no need to mess with additional maps or anything; if we detect raw L2/R2 or L3/R3 input we should send the right signal to chiaki to regardless (since it implies the user has a controller, not the vita alone).

But I guess it will take some investigation to determine how PSTV is interpreting inputs. I'm surprised that L1/R1 and L3/R3 don't work.

If you go to host.c lines 294-296, you can see where AA mapped L3/R3 input to L3/R3 output (I added the comment in 294 since I didn't know what L3/R3 could be on vita). So I would have guessed that L3/R3 would just work on PSTV due to these lines.... Similarly for L1/R1.

SCE_CTRL_L2 input is never handled, and again I would think that it would be sufficient to just add a couple lines after that to handle L2/R2, something like:

if (ctrl.buttons & SCE_CTRL_L2)       stream->controller_state.l2_state = 0xff;
if (ctrl.buttons & SCE_CTRL_R2)       stream->controller_state.r2_state = 0xff;

, but L1/R1 and L3/R3 not working means this probably won't have an effect either I guess.

I think the place to start would be searching through other vita projects (e.g., https://github.com/xyzz/vita-moonlight/) to see how they handle external controllers, and/or check the vita api docs (https://docs.vitasdk.org/group__SceCtrlUser.html) to figure out how the PSTV interprets controller button presses.

(I'm out of town and typing this on my phone, so...this is about the best I can do rn)

[TheThomasD]

Great, thank you for the help. Not sure when I find the time to test. As for testing, I think one could also connect a PS3/PS4-Controller to the PS-Vita, so maybe this is also an option.

[ywnico]

@TheThomasD , PR #22 addressed a different issue, but since it affected how controller input is interpreted it may have changed the situation on PS TV. I don't think it will have resolved it, but I wonder if at least L2/R2 and L3/R3 inputs are detected now. I included it in an updated release, v0.06b.

[TheThomasD]

Funny, it was about a year ago when I requested this feature :D I seem to have time for using PS5 remote play only around new year...

@ywnico please consider merging my PR

Update: Works on PS-Vita as well.

[TheThomasD]

I also tested a PS4-Controller on the PSTV. It seems that the R3/L3 sticks trigger a touch intput (most likely directly on the PSTV). Not sure how to fix this. Any ideas welcome!

[TheThomasD]

I disabled touch in the PSTV (via long-press) and if I use mapping 200, it works fine for now (with exception of the touch input on the PS4 controller). I think this needs some debugging. If anyone has an idea how to fix this, I'd be happy to test (or implement, if needed).