Skip to content

Commit 725ad91

Browse files
committed
Fix convert-to-ami to use DinD
1 parent e0257d2 commit 725ad91

1 file changed

Lines changed: 21 additions & 17 deletions

File tree

Makefile

Lines changed: 21 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -79,32 +79,36 @@ convert-to-iso: bib-dind-up
7979
--type iso \
8080
--use-librepo=True \
8181
--rootfs ${ROOTFS} \
82-
${OCI_REGISTRY}/${OCI_IMAGE_REPO}:${OCI_IMAGE_TAG}-$${target}"; \
82+
${OCI_REGISTRY}/${OCI_IMAGE_REPO}:${OCI_IMAGE_TAG}-$${target}"; \
8383
done
8484
$(MAKE) bib-dind-down
8585

8686
# See https://github.com/osbuild/bootc-image-builder?tab=readme-ov-file#amazon-machine-images-amis
8787
.PHONY: convert-to-ami
88-
convert-to-ami:
88+
convert-to-ami: bib-dind-up
8989
AWS_AMI_NAME=${SHORT_COMMIT_HASH}-core; \
90-
sudo podman load -i image-${SHORT_COMMIT_HASH}-core.tar.gz; \
9190
cp -rf template-ami.toml config.toml; \
9291
sed -i "s|{DEFAULT_USER_NAME}|${DEFAULT_USER_NAME}|g" config.toml; \
9392
sed -i "s|{DEFAULT_USER_PASSWD}|${DEFAULT_USER_PASSWD}|g" config.toml; \
94-
sudo docker run --rm \
95-
--privileged \
96-
--security-opt label=type:unconfined_t \
97-
-v /var/lib/containers/storage:/var/lib/containers/storage \
98-
-v ./config.toml:/config.toml:ro \
99-
--env AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID} \
100-
--env AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY} \
101-
${BIB_CONTAINER} \
102-
--type ami \
103-
--rootfs ${ROOTFS} \
104-
--aws-ami-name $${AWS_AMI_NAME} \
105-
--aws-bucket ${AWS_S3_BUCKET} \
106-
--aws-region ${AWS_REGION} \
107-
${OCI_REGISTRY}/${OCI_IMAGE_REPO}:${OCI_IMAGE_TAG}-core
93+
docker cp config.toml bib-dind:/config.toml; \
94+
docker exec bib-dind /bin/bash -c " \
95+
podman load -i container-tarbells/image-${SHORT_COMMIT_HASH}-core.tar.gz; \
96+
podman run --rm \
97+
--privileged \
98+
--security-opt label=type:unconfined_t \
99+
-v /var/lib/containers/storage:/var/lib/containers/storage \
100+
-v ./config.toml:/config.toml:ro \
101+
-v ./filesystem/etc/selinux:/etc/selinux:ro \
102+
--env AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID} \
103+
--env AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY} \
104+
${BIB_CONTAINER} \
105+
--type ami \
106+
--rootfs ${ROOTFS} \
107+
--aws-ami-name $${AWS_AMI_NAME} \
108+
--aws-bucket ${AWS_S3_BUCKET} \
109+
--aws-region ${AWS_REGION} \
110+
${OCI_REGISTRY}/${OCI_IMAGE_REPO}:${OCI_IMAGE_TAG}-core"; \
111+
$(MAKE) bib-dind-down
108112

109113
.PHONY: bib-dind-up
110114
bib-dind-up:

0 commit comments

Comments
 (0)