From 3cee8cf041d89469508d525c4f5d8304d7b6570c Mon Sep 17 00:00:00 2001
From: Sanyam Singhal <ssinghal@yugabyte.com>
Date: Tue, 7 Jan 2025 16:50:28 +0000
Subject: [PATCH] added impact for issues missed before

---
 yb-voyager/cmd/assessMigrationCommand.go      | 1 +
 yb-voyager/src/query/queryissue/issues_ddl.go | 1 +
 yb-voyager/src/query/queryissue/issues_dml.go | 6 ++++++
 3 files changed, 8 insertions(+)

diff --git a/yb-voyager/cmd/assessMigrationCommand.go b/yb-voyager/cmd/assessMigrationCommand.go
index 1f31e940e..43eafe429 100644
--- a/yb-voyager/cmd/assessMigrationCommand.go
+++ b/yb-voyager/cmd/assessMigrationCommand.go
@@ -1175,6 +1175,7 @@ func fetchUnsupportedObjectTypes() ([]UnsupportedFeature, error) {
 			referenceOrTablePartitionPresent = true
 			unsupportedPartitionTypes = append(unsupportedPartitionTypes, ObjectInfo{ObjectName: fmt.Sprintf("Table Name: %s, Partition Method: %s", objectName, objectType)})
 
+			// For oracle migration complexity comes from ora2pg, so defining Impact not required right now
 			assessmentReport.AppendIssues(AssessmentIssue{
 				Category:   constants.FEATURE,
 				Type:       "", // TODO
diff --git a/yb-voyager/src/query/queryissue/issues_ddl.go b/yb-voyager/src/query/queryissue/issues_ddl.go
index 1187ec810..7a06bcaa0 100644
--- a/yb-voyager/src/query/queryissue/issues_ddl.go
+++ b/yb-voyager/src/query/queryissue/issues_ddl.go
@@ -503,6 +503,7 @@ func NewSecurityInvokerViewIssue(objectType string, objectName string, SqlStatem
 var foreignKeyReferencesPartitionedTableIssue = issue.Issue{
 	Type:       FOREIGN_KEY_REFERENCES_PARTITIONED_TABLE,
 	Name:       FOREIGN_KEY_REFERENCES_PARTITIONED_TABLE_NAME,
+	Impact:     constants.IMPACT_LEVEL_1,
 	Suggestion: "No workaround available ",
 	GH:         "", // TODO
 	DocsLink:   "", // TODO
diff --git a/yb-voyager/src/query/queryissue/issues_dml.go b/yb-voyager/src/query/queryissue/issues_dml.go
index 93035ed87..2b8603531 100644
--- a/yb-voyager/src/query/queryissue/issues_dml.go
+++ b/yb-voyager/src/query/queryissue/issues_dml.go
@@ -82,6 +82,7 @@ func NewRegexFunctionsIssue(objectType string, objectName string, sqlStatement s
 var aggregateFunctionIssue = issue.Issue{
 	Type:            AGGREGATE_FUNCTION,
 	Name:        AGGREGATION_FUNCTIONS_NAME,
+	Impact:      constants.IMPACT_LEVEL_2,
 	Description: "any_value, range_agg and range_intersect_agg functions not supported yet in YugabyteDB",
 	Suggestion:      "",
 	GH:              "",
@@ -99,6 +100,7 @@ func NewAggregationFunctionIssue(objectType string, objectName string, sqlStatem
 var jsonConstructorFunctionsIssue = issue.Issue{
 	Type:        JSON_CONSTRUCTOR_FUNCTION,
 	Name:        JSON_CONSTRUCTOR_FUNCTION_NAME,
+	Impact:      constants.IMPACT_LEVEL_2,
 	Description: "Postgresql 17 features not supported yet in YugabyteDB",
 	Suggestion:  "",
 	GH:          "",
@@ -116,6 +118,7 @@ func NewJsonConstructorFunctionIssue(objectType string, objectName string, sqlSt
 var jsonQueryFunctionIssue = issue.Issue{
 	Type:        JSON_QUERY_FUNCTION,
 	Name:        JSON_QUERY_FUNCTIONS_NAME,
+	Impact:      constants.IMPACT_LEVEL_2,
 	Description: "Postgresql 17 features not supported yet in YugabyteDB",
 	Suggestion:  "",
 	GH:          "",
@@ -133,6 +136,7 @@ func NewJsonQueryFunctionIssue(objectType string, objectName string, sqlStatemen
 var loFunctionsIssue = issue.Issue{
 	Type:        LARGE_OBJECT_FUNCTIONS,
 	Name:        LARGE_OBJECT_FUNCTIONS_NAME,
+	Impact:      constants.IMPACT_LEVEL_2,
 	Description: "Large Objects functions are not supported in YugabyteDB",
 	Suggestion:  "Large objects functions are not yet supported in YugabyteDB, no workaround available right now",
 	GH:          "https://github.com/yugabyte/yugabyte-db/issues/25318",
@@ -150,6 +154,7 @@ func NewLOFuntionsIssue(objectType string, objectName string, sqlStatement strin
 var jsonPredicateIssue = issue.Issue{
 	Type:            JSON_TYPE_PREDICATE,
 	Name:        JSON_TYPE_PREDICATE_NAME,
+	Impact:      constants.IMPACT_LEVEL_2,
 	Description: "IS JSON predicate expressions not supported yet in YugabyteDB",
 	Suggestion:      "",
 	GH:              "",
@@ -191,6 +196,7 @@ func NewCopyOnErrorIssue(objectType string, objectName string, sqlStatement stri
 var fetchWithTiesIssue = issue.Issue{
 	Type:        FETCH_WITH_TIES,
 	Name:        "FETCH .. WITH TIES",
+	Impact:      constants.IMPACT_LEVEL_2,
 	Description: "FETCH .. WITH TIES is not supported in YugabyteDB",
 	Suggestion:  "No workaround available right now",
 	GH:          "",