Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming tonic upgrade #280

Closed
AmeliasCode opened this issue Jun 18, 2024 · 4 comments
Closed

Upcoming tonic upgrade #280

AmeliasCode opened this issue Jun 18, 2024 · 4 comments

Comments

@AmeliasCode
Copy link
Contributor

Tonic has recently under gone a massive refactor to support hyper 1.0. This inevitably requires some effort to support. Fortunately, that effort is fairly low and mostly consists of updating dependencies and resynthesizing the googleapis generated code. I have a branch on my fork that does this already.

Once the tonic update is released I can raise a PR, but this will be a breaking change and folks will have to either update their other dependencies or not update their google-cloud-* dependencies.

What are your thoughts on how to best handle this?

@yoshidan
Copy link
Owner

yoshidan commented Jun 24, 2024

I have checked the following fixes.

https://github.com/AmeliasCode/google-cloud-rust/compare/main..tonic-update

I think it is ok to update the dependency as the modification has been done to the extent of regenerating google-cloud-googleapis.

I will update tonic and see if there is a problem with the operation too.

@BeauGieskens
Copy link

Now that tonic v0.12.0 is here, I'm keen to see it adopted by these libraries soon.

We're using google-cloud-pubsub in an Axum server and I think this update is the last thing stopping us from updating to the latest Axum version (with hyper 1.0 support).

@yoshidan
Copy link
Owner

yoshidan commented Jul 9, 2024

#283
We are currently checking for problems in the test environment. Will merge when completed.

@yoshidan
Copy link
Owner

Now I released v0.28.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants