Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose pubsub SubscriberClient for lease management #214

Closed
pocesar opened this issue Nov 22, 2023 · 1 comment
Closed

expose pubsub SubscriberClient for lease management #214

pocesar opened this issue Nov 22, 2023 · 1 comment

Comments

@pocesar
Copy link
Contributor

pocesar commented Nov 22, 2023

https://cloud.google.com/pubsub/docs/lease-management

According to the docs, a ModifyAckDeadlineRequest can be sent to extend the default 600s max limit.
It's not possible to extend the deadline as the SubscriberClient is pub(crate) and subc is also private.

Ideally this should be attached to the ReceivedMessage itself, so it can be extended while also being able to ack/nack. Another solution would to implement a fn client(&self) -> &SubscriberClient on Subscription

Using subscription.receive is currently impossible to implement on the codebase.

The use case is distributed worker that deals with 1 message at a time, but scales horizontally, but sometimes it can take much longer than 10 minutes to complete (~20 min), and using the streaming subscribe leads to a lot of unnecessary retries

@pocesar
Copy link
Contributor Author

pocesar commented Jul 1, 2024

#215 has been working fine in production for us, I guess this is done 😃

@pocesar pocesar closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant