Update dev dependencies & fix CI (#52)

yann-eugone · web-flow · commit 4a11cdc7dcdb · 2022-02-28T08:47:45.000+01:00
* Updated GitHub versions for non test jobs

* Updated dev dependencies

* Fix phpstan after update

* Add tests to cover changes

* Remove symplify/monorepo-builder from all CI jobs
diff --git a/composer.json b/composer.json
@@ -22,7 +22,7 @@
         }
     },
     "require-dev": {
-        "phpunit/phpunit": "^9.4"
+        "phpunit/phpunit": "^9.5"
     },
     "autoload-dev": {
         "psr-4": {
diff --git a/src/DependencyInjection/CompilerPass/RegisterJobsCompilerPass.php b/src/DependencyInjection/CompilerPass/RegisterJobsCompilerPass.php
@@ -35,8 +35,8 @@ public function process(ContainerBuilder $container): void
      */
     private function getJobName(string $id, Definition $definition, array $attributes): string
     {
-        if (isset($attributes['job'])) {
-            return (string)$attributes['job'];
+        if (isset($attributes['job']) && \is_string($attributes['job'])) {
+            return $attributes['job'];
         }
 
         $serviceClass = $definition->getClass();

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@`
`22`	`22`	`}`
`23`	`23`	`},`
`24`	`24`	`"require-dev": {`
`25`		`- "phpunit/phpunit": "^9.4"`
	`25`	`+ "phpunit/phpunit": "^9.5"`
`26`	`26`	`},`
`27`	`27`	`"autoload-dev": {`
`28`	`28`	`"psr-4": {`
Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,8 @@ public function process(ContainerBuilder $container): void`
`35`	`35`	`*/`
`36`	`36`	`private function getJobName(string $id, Definition $definition, array $attributes): string`
`37`	`37`	`{`
`38`		`- if (isset($attributes['job'])) {`
`39`		`- return (string)$attributes['job'];`
	`38`	`+ if (isset($attributes['job']) && \is_string($attributes['job'])) {`
	`39`	`+ return $attributes['job'];`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`$serviceClass = $definition->getClass();`